Reuse and hot reload folder handles #10210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasEi
force-pushed
the
reuse_and_reload_folder_handles
branch
from
7e21e69 to
3a89d9c
Compare
NiklasEi
added
C-Feature
4 tasks
…eir content changes
NiklasEi
force-pushed
the
reuse_and_reload_folder_handles
branch
from
3a89d9c to
3bf15bf
Compare
alice-i-cecile
requested changes
Oct 24, 2023
…ad_folder_handles
alice-i-cecile
approved these changes
Oct 25, 2023
|
I extensively tested this change together with asset processing using the |
alice-i-cecile
approved these changes
Oct 25, 2023
cart
approved these changes
Oct 26, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective - Folder handles are not shared. Loading the same folder multiple times will result in different handles. - Once folder handles are shared, they can no longer be manually reloaded, so we should add support for hot-reloading them ## Solution - Reuse folder handles based on their path - Trigger a reload of a folder if a file contained in it (or a sub folder) is added or removed - This also covers adding/removing/moving sub folders containing files --------- Co-authored-by: Carter Anderson <mcanders1@gmail.com>
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Folder handles are not shared. Loading the same folder multiple times will result in different handles. - Once folder handles are shared, they can no longer be manually reloaded, so we should add support for hot-reloading them ## Solution - Reuse folder handles based on their path - Trigger a reload of a folder if a file contained in it (or a sub folder) is added or removed - This also covers adding/removing/moving sub folders containing files --------- Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution