Fix missing explicit lifetime name for copy_deferred_lighting_id name #10128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Oct 15, 2023
alice-i-cecile
added
A-Rendering
superdump
approved these changes
Oct 15, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
…bevyengine#10128) # Objective On nightly there is a warning on a missing lifetime: ```bash warning: `&` without an explicit lifetime name cannot be used here ``` The details are in rust-lang/rust#115010, but the bottom line is that in associated constants elided lifetimes are no longer allowed to be implicitly defined. This fixes the only place where it is missing. ## Solution - Add explicit `'static` lifetime
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…bevyengine#10128) # Objective On nightly there is a warning on a missing lifetime: ```bash warning: `&` without an explicit lifetime name cannot be used here ``` The details are in rust-lang/rust#115010, but the bottom line is that in associated constants elided lifetimes are no longer allowed to be implicitly defined. This fixes the only place where it is missing. ## Solution - Add explicit `'static` lifetime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
On nightly there is a warning on a missing lifetime:
warning: `&` without an explicit lifetime name cannot be used hereThe details are in rust-lang/rust#115010, but the bottom line is that in associated constants elided lifetimes are no longer allowed to be implicitly defined.
This fixes the only place where it is missing.
Solution
'staticlifetime