Allow windows to be maximized. #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
reviewed
Dec 4, 2020
crates/bevy_window/src/window.rs
Outdated
| @@ -37,6 +37,7 @@ pub struct Window { | |||
| id: WindowId, | |||
| width: u32, | |||
| height: u32, | |||
| maximized: bool, | |||
There was a problem hiding this comment.
This state will be hard to keep "up to date" because users can resize the window. Additionally, maximizing isn't supported on some platforms (android, ios, web), but this would happily report it as maximized. I think (for now) we should probably just drop it to avoid mis-reporting the state.
| pub fn maximized(&self) -> bool { | ||
| self.maximized | ||
| } | ||
|
|
||
| pub fn set_resolution(&mut self, width: u32, height: u32) { |
There was a problem hiding this comment.
Can we add a set_maximized(&mut self, maximized: bool) function that produces a WindowCommand? It would be nice to let people maximize on-demand.
frewsxcv
changed the title
|
@cart Feedback has been addressed |
|
Awesome! Just fix the formatting issue (either manually or by running |
Adds a new `set_maximized` method to allow users to maximize windows.
|
Done |
Moxinilian
added
C-Enhancement
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
set_maximizedmethod to allow users to maximize windows.