Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morph targets are jerky #9898

Closed
nicopap opened this issue Sep 22, 2023 · 0 comments · Fixed by #9927
Closed

Morph targets are jerky #9898

nicopap opened this issue Sep 22, 2023 · 0 comments · Fixed by #9927
Labels
A-Animation Make things move and change over time A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@nicopap
Copy link
Contributor

nicopap commented Sep 22, 2023

  • bevy version: 0.12-dev, main as of 401b2e7

Morph target animations are not smooth. It can be observed on a high frame rate monitor when running the morph_targets example.

It is especially visible when we slow down animations using the set_speed() animation modifier.

Video evidence

In this video, the fox is the classic skinned animated fox from the bevy examples. While the dragon uses morph targets for the wings. You can see how morph targets are not properly animated, and look super jerky.

bevy_motion_vec_anim_2-2023-09-22.mp4
@nicopap nicopap added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen A-Animation Make things move and change over time labels Sep 22, 2023
@nicopap nicopap added the D-Trivial Nice and easy! A great choice to get started with Bevy label Sep 23, 2023
github-merge-queue bot pushed a commit that referenced this issue Sep 27, 2023
# Objective
Fixes: #9898
## Solution
Make morph behave like other keyframes, lerping first between start and
end, and then between the current state and the result.

## Changelog
Fixed jerky morph targets

---------

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Co-authored-by: CGMossa <cgmossa@gmail.com>
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
# Objective
Fixes: bevyengine#9898
## Solution
Make morph behave like other keyframes, lerping first between start and
end, and then between the current state and the result.

## Changelog
Fixed jerky morph targets

---------

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Co-authored-by: CGMossa <cgmossa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Animation Make things move and change over time A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@nicopap and others