Panic whilst loading ktx2 file

[66OJ66]

Bevy version

v0.11.0

[Optional] Relevant system information

Rust 1.70
OS: openSUSE Tumbleweed

`AdapterInfo { name: "AMD Radeon RX 6600 XT (RADV NAVI23)", vendor: 4098, device: 29695, device_type: DiscreteGpu, driver: "radv", driver_info: "Mesa 23.1.2", backend: Vulkan }`

What went wrong

I attempted to load a ktx2 file which led to the following panic.

2023-07-11T22:23:24.829163Z ERROR wgpu::backend::direct: Handling wgpu errors as fatal by default    
thread 'Compute Task Pool (5)' panicked at 'wgpu error: Validation Error

Caused by:
    In Device::create_texture
    Texture format Astc { block: B4x4, channel: UnormSrgb } can't be used due to missing features.
    Features Features(TEXTURE_COMPRESSION_ASTC) are required but not enabled on the device

', /home/_/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-0.16.2/src/backend/direct.rs:3019:5

This file loaded without issue in Bevy v0.10.1 (and earlier) with these features enabled:

[dependencies]
bevy = { version = "0.10.1", features = ["ktx2", "zstd", "basis-universal"]}

Additional information

I've uploaded a basic example here: https://github.com/66OJ66/basis_universal_error_repo

The original PNG file was sourced from here: https://ambientcg.com/view?id=Ground037

I converted it to ktx2 using toktx (https://github.khronos.org/KTX-Software/ktxtools/toktx.html).
The exact command was:
toktx --encode uastc --zcmp 22 --genmipmap --uastc_rdo_l 0.5 {output} {input.png}

[Elabajaba]

I don't know how this worked previously, but the only desktop/laptop hardware that supported ASTC was Intel iGPUs, and they dropped support for it in recent hardware.

edit: I guess previously it was somehow autoconverting it with basis-universal stuff somehow?

edit2: It seems like #8336 is when the crashing started.

[66OJ66]

edit2: It seems like #8336 is when the crashing started.

Yeah, I checked the original PR where compressed texture support was added, and this comment mentioned an potential issue with WebGPU: #3884 (comment)

[66OJ66]

After investigating a bit more, this is caused by a combination of 2 issues:

1. If the RenderDevice resource is missing when the ImageTextureLoader is initialised, it defaults to supporting all compressed textures (line 85)
   

   bevy/crates/bevy_render/src/texture/image_texture_loader.rs

   Lines 80 to 91 in 05a35f6

   	impl FromWorld for ImageTextureLoader {
   	fn from_world(world: &mut World) -> Self {
   	let supported_compressed_formats = match world.get_resource::<RenderDevice>() {
   	Some(render_device) => CompressedImageFormats::from_features(render_device.features()),
   	None => CompressedImageFormats::all(),
   	};
   	Self {
   	supported_compressed_formats,
   	}
   	}
   	}

2. The RenderPlugin and ImagePlugin are added sequentially, but in Webgpu support #8336 the renderer initialisation was made async. As a result, now at the time of ImagePlugin initialisation the RenderDevice resource doesn't exist yet, triggering the fallback condition above
   

   bevy/crates/bevy_internal/src/default_plugins.rs

   Lines 76 to 82 in 05a35f6

   	#[cfg(feature = "bevy_render")]
   	{
   	group = group
   	.add(bevy_render::RenderPlugin::default())
   	// NOTE: Load this after renderer initialization so that it knows about the supported
   	// compressed texture formats
   	.add(bevy_render::texture::ImagePlugin::default());

So, fixing this should just be a case of delaying the ImageTextureLoader initalisation within ImagePlugin - I'll prepare a PR for this shortly