Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StartupSet and RenderSet base sets #7573

Closed
TimJentzsch opened this issue Feb 8, 2023 · 0 comments
Closed

Make StartupSet and RenderSet base sets #7573

TimJentzsch opened this issue Feb 8, 2023 · 0 comments
Labels
A-ECS Entities, components, systems, and events C-Enhancement A new feature
Milestone
0.10

Comments

@TimJentzsch
Copy link
Contributor

What problem does this solve or what need does it fill?

StartupSet and RenderSet are not base sets, but they probably should be.

What solution would you like?

Add #[system_set(base)] to the enum and use in_base_set instead of in_set.

Additional context
@TimJentzsch TimJentzsch added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Feb 8, 2023
@TimJentzsch TimJentzsch mentioned this issue Feb 8, 2023
Closed
@JMS55 JMS55 added A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels Feb 9, 2023
@cart cart added this to the 0.10 milestone Feb 9, 2023
@bors bors bot closed this as completed in 9b7060c Feb 19, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this issue Feb 20, 2023
@TimJentzsch @myreprise1
Make StartupSet a base set (bevyengine#7574)
87b7adf 
# Objective

Closes bevyengine#7573

- Make `StartupSet` a base set

## Solution

- Add `#[system_set(base)]` to the enum declaration
- Replace `.in_set(StartupSet::...)` with `.in_base_set(StartupSet::...)`

**Note**: I don't really know what I'm doing and what exactly the difference between base and non-base sets are. I mostly opened this PR based on discussion in Discord. I also don't really know how to test that I didn't break everything. Your reviews are appreciated!

---

## Changelog

- `StartupSet` is now a base set

## Migration Guide

`StartupSet` is now a base set. This means that you have to use `.in_base_set` instead of `.in_set`:

### Before

```rs
app.add_system(foo.in_set(StartupSet::PreStartup))
```

### After

```rs
app.add_system(foo.in_base_set(StartupSet::PreStartup))
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Enhancement A new feature
Projects
None yet
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Make StartupSet a base set TimJentzsch/bevy
3 participants
@cart @TimJentzsch @JMS55