Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "how to adopt pull requests" section in Contributing.md #5539

Closed
Weibye opened this issue Aug 1, 2022 · 1 comment
Closed

Add "how to adopt pull requests" section in Contributing.md #5539

Weibye opened this issue Aug 1, 2022 · 1 comment
Labels
A-Meta About the project itself C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@Weibye
Copy link
Contributor

Weibye commented Aug 1, 2022

How can Bevy's documentation be improved?

When encountering PRs labeled S-Adopt-Me I'm unsure what is the correct way to "adopt a PR" that also preserves credit of the original authors.

We should add a section in the CONTRIBUTING.md explaining a short how-to-guide of correctly adopting pull requests
@Weibye Weibye added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Meta About the project itself labels Aug 1, 2022
@oCaioOliveira
Copy link
Contributor

Hello @Weibye, I and @ErickMVdO are going to contribute with this issue.

oCaioOliveira added a commit to oCaioOliveira/bevy that referenced this issue Dec 9, 2022
@oCaioOliveira @ErickMVdO
Add topic How to adopt pull request
b62f9fd 
Fixes bevyengine#5539

Co-authored-by: Erick <erickmelovidal@gmail.com>
oCaioOliveira added a commit to oCaioOliveira/bevy that referenced this issue Dec 9, 2022
@oCaioOliveira @ErickMVdO
Add "how to adopt pull requests" section
48aab46 
Fixes bevyengine#5539

Co-authored-by: Erick <erickmelovidal@gmail.com>
@oCaioOliveira oCaioOliveira mentioned this issue Dec 9, 2022
Closed
@bors bors bot closed this as completed in 1aeaafa Dec 22, 2022
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@oCaioOliveira @ErickMVdO @alradish
Add "how to adopt pull requests" section (bevyengine#6895)
5fb52d8 
# Objective

- Add "how to adopt pull requests" section.
- Fixes bevyengine#5539

## Solution

- Add "how to adopt pull requests" section in [Contributing.md](https://github.com/bevyengine/bevy/blob/main/CONTRIBUTING.md).

Co-authored-by: Erick <erickmelovidal@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@oCaioOliveira @ErickMVdO @ItsDoot
Add "how to adopt pull requests" section (bevyengine#6895)
f1546a1 
# Objective

- Add "how to adopt pull requests" section.
- Fixes bevyengine#5539

## Solution

- Add "how to adopt pull requests" section in [Contributing.md](https://github.com/bevyengine/bevy/blob/main/CONTRIBUTING.md).

Co-authored-by: Erick <erickmelovidal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Meta About the project itself C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Add "how to adopt pull requests" section oCaioOliveira/bevy
2 participants
@Weibye @oCaioOliveira