Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling hot asset reloading freezes application when asset file is changed. #375

Closed
mrk-its opened this issue Aug 27, 2020 · 0 comments · Fixed by #376
Closed

Enabling hot asset reloading freezes application when asset file is changed. #375

mrk-its opened this issue Aug 27, 2020 · 0 comments · Fixed by #376
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior

Comments

@mrk-its
Copy link
Member

mrk-its commented Aug 27, 2020

When asset change detection is enabled by asset_server.watch_for_changes().unwrap(); application freezes if asset file is modified.
The reason is deadlock in filesystem_watcher_system (PR is in progress)

Proposed labels: asset, bug
mrk-its added a commit to mrk-its/bevy that referenced this issue Aug 27, 2020
@mrk-its
Fix deadlock in hot asset reloading (bevyengine#375)
4a96fb7
@mrk-its mrk-its mentioned this issue Aug 27, 2020
Merged
@karroffel karroffel added A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior labels Aug 28, 2020
@cart cart closed this as completed in #376 Aug 30, 2020
cart pushed a commit that referenced this issue Aug 30, 2020
@mrk-its
Fix deadlock in hot asset reloading (#375) (#376)
8101622
mrk-its added a commit to mrk-its/bevy that referenced this issue Oct 6, 2020
@mrk-its
Fix deadlock in hot asset reloading (bevyengine#375) (bevyengine#376)
77c98ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deadlock in hot asset reloading (#375) mrk-its/bevy
2 participants
@mrk-its @karroffel