Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-threaded feature name is kebab case but all others are snake case #12966

Closed
alice-i-cecile opened this issue Apr 14, 2024 · 4 comments · Fixed by #12997
Closed

multi-threaded feature name is kebab case but all others are snake case #12966

alice-i-cecile opened this issue Apr 14, 2024 · 4 comments · Fixed by #12997
Labels
A-Cross-Cutting Impacts the entire engine C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide

Comments

@alice-i-cecile
Copy link
Member

Bevy version

0.14

What went wrong

See

bevy/Cargo.toml

Line 70 in 62f2a73

"multi-threaded",

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide A-Cross-Cutting Impacts the entire engine labels Apr 14, 2024
@BD103
Copy link
Member

BD103 commented Apr 15, 2024

There are actually quite a few features that use kebab case, such as all the symphonia-* ones. Should those also be changed, or just multi-threaded?

@alice-i-cecile
Copy link
Member Author

Oh so there is. We should change all of the ones that aren't deliberately matching a dependencies' feature IMO.

@andristarr andristarr mentioned this issue Apr 16, 2024
Merged
@mockersf
Copy link
Member

so, this issue doesn't mention the expected fix: should all features be kebab case?

@alice-i-cecile
Copy link
Member Author

I would prefer all snake case for consistency with crate names :) But really I don't care, as long as it's consistent.

github-merge-queue bot pushed a commit that referenced this issue May 6, 2024
@andristarr
multi_threaded feature rename (#12997)
bb76a2c 
# Objective

Fixes #12966

## Solution

Renaming multi_threaded feature to match snake case

## Migration Guide

Bevy feature multi-threaded should be refered to multi_threaded from now
on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multi_threaded feature rename andristarr/bevy
3 participants
@alice-i-cecile @mockersf @BD103