Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_color: Add fluent methods to color types. #12075

Closed
viridia opened this issue Feb 24, 2024 · 0 comments · Fixed by #12099
Closed

bevy_color: Add fluent methods to color types. #12075

viridia opened this issue Feb 24, 2024 · 0 comments · Fixed by #12099
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use
Milestone
0.14

Comments

@viridia
Copy link
Contributor

viridia commented Feb 24, 2024

Several people have requested "fluent" methods such as .with_red(). These should only exist in cases where they are cheap, in other words, no implicit conversions. There should be a .with_ method for each of the defined color channels (.with_alpha already exists.)
@viridia viridia added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Feb 24, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Feb 24, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Feb 24, 2024
viridia added a commit to viridia/bevy that referenced this issue Feb 24, 2024
@viridia
Adding "fluent" methods to modify color channels.
75ce42b 
Fixes bevyengine#12075
@viridia viridia mentioned this issue Feb 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 24, 2024
@viridia
Adding "fluent" methods to modify color channels. (#12099)
10aef14 
Fixes #12075
msvbg pushed a commit to msvbg/bevy that referenced this issue Feb 26, 2024
@viridia @msvbg
Adding "fluent" methods to modify color channels. (bevyengine#12099)
dcaa2cb 
Fixes bevyengine#12075
msvbg pushed a commit to msvbg/bevy that referenced this issue Feb 26, 2024
@viridia @msvbg
Adding "fluent" methods to modify color channels. (bevyengine#12099)
975e7c2 
Fixes bevyengine#12075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Adding "fluent" methods to modify color channels. viridia/bevy
2 participants
@viridia @alice-i-cecile