Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken rendering wireframes on windows / DX12 #10019

Closed
alice-i-cecile opened this issue Oct 4, 2023 · 9 comments · Fixed by #10022
Closed

Broken rendering wireframes on windows / DX12 #10019

alice-i-cecile opened this issue Oct 4, 2023 · 9 comments · Fixed by #10022
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this!
Milestone
0.12

Comments

@alice-i-cecile
Copy link
Member 

          it seems this PR broke rendering wireframes on windows / DX12

4a70c28683d006612a308b440640b77d41660816281512fad182519013d51071

Originally posted by @mockersf in #7328 (comment)
@alice-i-cecile alice-i-cecile added this to the 0.12 milestone Oct 4, 2023
@alice-i-cecile alice-i-cecile added C-Regression Functionality that used to work but no longer does. Add a test for this! C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-High This is particularly urgent, and deserves immediate attention labels Oct 4, 2023
@alice-i-cecile
Copy link
Member Author

I think just reverting for now is likely the safest choice, but if y'all can find another fix I'm happy to take a look.

@IceSentry
Copy link
Contributor

I don't think this is a new bug, the PR didn't touch any rendering code.

I just tested it with bevy before the PR and wireframes were already broken with DX12

@alice-i-cecile alice-i-cecile removed the P-High This is particularly urgent, and deserves immediate attention label Oct 4, 2023
@mockersf
Copy link
Member

mockersf commented Oct 4, 2023

I can't test locally DX12, but it's running as part of https://vleue.com/bevy-example-tests/index.html
Wireframes on Windows/DX12 were working before the last two commits on main

@IceSentry
Copy link
Contributor

So, I'm not entirely sure what the issue is yet, but I know why this tool didn't show you the error. It only shows up on the plane mesh but before that PR the plane was disabled. I needed to enable the global wireframe to show the issue.

@IceSentry
Copy link
Contributor

I'm still digging, but 0.11.3 works correctly but 20ed3e0 doesn't

@IceSentry
Copy link
Contributor

Alright, found the commit where it started ae6bc08 it's #9734

@mockersf 👀

@IceSentry
Copy link
Contributor

To be clear, this only happens with the DX12 backend, Vulkan backend is fine.

Technically it's also broken on the webgpu backend, but line drawing isn't supported on that backend so the fact that it renders anything is a wgpu bug that will be fixed.

@mockersf
Copy link
Member

mockersf commented Oct 4, 2023

Alright, found the commit where it started ae6bc08 it's #9734

@mockersf 👀

nice, thanks for digging!

This was referenced Oct 4, 2023
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 4, 2023
@mockersf
wireframes: workaround for DX12 (#10022)
9086e60 
# Objective

- Fixes #10019

## Solution

- Uses a workaround for DX12
@superdump
Copy link
Contributor

I was going to say - it looks like it's loading the wrong transforms from instance data, and I remembered that there was an instance index workaround for DX12 misbehaviour.

regnarock pushed a commit to regnarock/bevy that referenced this issue Oct 13, 2023
@mockersf
wireframes: workaround for DX12 (bevyengine#10022)
9f5013e 
# Objective

- Fixes bevyengine#10019

## Solution

- Uses a workaround for DX12
ameknite pushed a commit to ameknite/bevy that referenced this issue Nov 6, 2023
@mockersf @ameknite
wireframes: workaround for DX12 (bevyengine#10022)
aec7a59 
# Objective

- Fixes bevyengine#10019

## Solution

- Uses a workaround for DX12
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
@mockersf
wireframes: workaround for DX12 (bevyengine#10022)
6efbc73 
# Objective

- Fixes bevyengine#10019

## Solution

- Uses a workaround for DX12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

wireframes: workaround for DX12 mockersf/bevy
4 participants
@superdump @alice-i-cecile @IceSentry @mockersf