Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-1465] Fix image stitching for greyscale images #499

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

khughes-bdai
Copy link
Collaborator

@khughes-bdai khughes-bdai commented Oct 3, 2024

Change Overview

Image stitcher currently crashes if run on a spot with greyscale cameras, this should resolve that error.
See: #448

Testing Done

  • image stitcher on a spot with RGB cameras still works as expected
  • image stitcher on a spot with greyscale cameras doesn't crash and produces meaningful stitched images.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @khughes-bdai and the rest of your teammates on Graphite Graphite

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11169291618

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.099%

Totals Coverage Status
Change from base Build 11164121296: 0.0%
Covered Lines: 1929
Relevant Lines: 3775

💛 - Coveralls

Copy link
Collaborator Author

Testing succeeded on greyscale spot 🎉

Copy link
Collaborator Author

khughes-bdai commented Oct 7, 2024

Merge activity

@khughes-bdai khughes-bdai merged commit 188c86e into main Oct 7, 2024
6 checks passed
@khughes-bdai khughes-bdai deleted the khughes/greyscale_stitched_images branch October 7, 2024 19:29
AngelRodriguez8008 added a commit to AngelRodriguez8008/spot_ros2 that referenced this pull request Oct 26, 2024
* main: (23 commits)
  [dependabot] Bump spot_wrapper from `61c2574` to `76e522b` (bdaiinstitute#517)
  [SW-1483] Reorganize ROS 2 control packages (bdaiinstitute#511)
  [dependabot] Bump ros_utilities from `06077a2` to `23a79c9` (bdaiinstitute#513)
  [dependabot] Bump spot_wrapper from `f410423` to `61c2574` (bdaiinstitute#514)
  [dependabot] Bump spot_wrapper from `5c01ea7` to `f410423` (bdaiinstitute#512)
  Bump Spot SDK from `4.0.2` to `4.1.0` (bdaiinstitute#495)
  [MAPLE-743] Add hand posing non blocking option (bdaiinstitute#510)
  [SW-1481] Fix namespacing with spot ros2 control examples  (bdaiinstitute#505)
  [dependabot] Bump ros_utilities from `6ed50d7` to `06077a2` (bdaiinstitute#503)
  [MAPLE-743] Add Cartesian arm pose commands (bdaiinstitute#501)
  [SW-1465] Fix image stitching for greyscale images (bdaiinstitute#499)
  [SW-1391] controller that lets you specify position, velocity, and load at the same time  (bdaiinstitute#493)
  [dependabot] Bump ros_utilities from `e4f6138` to `6ed50d7` (bdaiinstitute#498)
  [dependabot] Bump ros_utilities from `2dc3c6b` to `e4f6138` (bdaiinstitute#496)
  [dependabot] Bump spot_wrapper from `2eec3ab` to `bde75c2` (bdaiinstitute#491)
  Updated navigateTo interface (bdaiinstitute#487)
  [MAPLE-663] Spot Gripper Angle Service (bdaiinstitute#488)
  [dependabot] Bump ros_utilities from `2d3e031` to `2dc3c6b` (bdaiinstitute#490)
  [dependabot] Bump ros_utilities from `e93bfc9` to `2d3e031` (bdaiinstitute#489)
  [SW-1394] add option for odom/fiducial/camera publishing from ros2 control launchfile (bdaiinstitute#485)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants