Rework CI to ensure up-to-date containers prior to builds #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhidalgo-bdai
commented
Feb 2, 2024
mhidalgo-bdai
commented
Feb 2, 2024
Comment on lines
+74
to
+75
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max |
There was a problem hiding this comment.
Layer caching will keep the cost of image re-builds at bay.
mhidalgo-bdai
commented
Feb 2, 2024
|
|
||
| jobs: | ||
| clean-ghcr: | ||
| name: Prune old images from Github Container Registry |
There was a problem hiding this comment.
Necessary to prevent PR specific images from accumulating in the institute's container registry.
mhidalgo-bdai
requested review from
METEORITENMAX,
jbarry-bdai,
mpickett-bdai,
bhung-bdai,
ksharma-bdai,
tcappellari-bdai and
khughes-bdai
as code owners
mhidalgo-bdai
force-pushed
the
rework-ci
branch
from
6f5264d to
5ab242d
Compare
|
Dependencies still wrong. I'll rework that and push once bdaiinstitute/spot_wrapper#85 lands. |
mhidalgo-bdai
force-pushed
the
rework-ci
branch
from
97652e2 to
3546166
Compare
|
Coveralls complains in |
bhung-bdai
reviewed
Feb 6, 2024
bhung-bdai
approved these changes
Feb 6, 2024
@bhung-bdai do you want that to happen in this PR or in a follow-up one? |
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
mhidalgo-bdai
force-pushed
the
rework-ci
branch
from
3546166 to
587b07f
Compare
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
mhidalgo-bdai
force-pushed
the
rework-ci
branch
from
923b2a3 to
96ee8e8
Compare
Pull Request Test Coverage Report for Build 7965081000Details
💛 - Coveralls |
amessing-bdai
approved these changes
Feb 20, 2024
marlow-fawn
pushed a commit
to marlow-fawn/spot_ros2
that referenced
this pull request
Aug 19, 2024
…ute#256) Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch merges lint, docker image build, and package build and test workflows into a single one, so as to ensure that package builds are performed in up-to-date containers. Similar to bdaiinstitute/ros_utilities#47. Necessary for #234.