No longer eagerly fetch labels in repo rule attributes #23371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eager fetching of all labels listed in repo rule attributes as introduced as a performance optimization when to avoid restarts. Now that restarts are gone by default, this is no longer a benefit as it can cause unnecessary fetches and also create cycles where there wouldn't be any without this behavior (e.g. when two repos write each others labels into a file without resolving them).
github-actions
bot
added
team-ExternalDeps
Wyverald
approved these changes
Aug 20, 2024
|
@bazel-io fork 7.4.0 |
Wyverald
added
awaiting-PR-merge
|
I fixed and deleted tests. |
|
We still have restarts for extensions, right? If an extension instantiates a repo rule, how does this affect it? |
We still have restarts for extensions, but their label attributes have never been fetched eagerly. Since repo rules are run lazily when needed, not inline when called by an extension, they will always be free of restarts even with this change. |
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Aug 22, 2024
Eager fetching of all labels listed in repo rule attributes was introduced as a performance optimization to avoid costly restarts. Now that restarts are gone by default, this is no longer a benefit as it can cause unnecessary fetches and also create cycles where there wouldn't be any without this behavior (e.g. when two repos write each others labels into a file without resolving them). Work towards bazelbuild#19055 Closes bazelbuild#23371. PiperOrigin-RevId: 665744319 Change-Id: Ia27f207793a2da3fb8e37743b328483f9d45192c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eager fetching of all labels listed in repo rule attributes was introduced as a performance optimization to avoid costly restarts.
Now that restarts are gone by default, this is no longer a benefit as it can cause unnecessary fetches and also create cycles where there wouldn't be any without this behavior (e.g. when two repos write each others labels into a file without resolving them).
Work towards #19055