Let repo rule attributes reference extension apparent names #23369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
19055-lazy-repo-mapping
branch
3 times, most recently
from
94bd2b6
to
39dde25
Compare
fmeum
changed the title
fmeum
force-pushed
the
19055-lazy-repo-mapping
branch
from
39dde25
to
f583cca
Compare
fmeum
requested review from
brandjon,
tetromino,
gregestren,
fweikert,
Wyverald and
meteorcloudy
as code owners
github-actions
bot
added
team-ExternalDeps
|
This is currently stacked on #23371. |
fmeum
force-pushed
the
19055-lazy-repo-mapping
branch
from
426d02b
to
7b674cd
Compare
|
I fixed up the error messages and also rebased on master. |
Wyverald
reviewed
Aug 21, 2024
| */ | ||
| public ImmutableMap<String, RepoSpec> createAndGetRepos(StarlarkSemantics starlarkSemantics) | ||
| throws EvalException, InterruptedException { | ||
| // LINT.IfChange |
There was a problem hiding this comment.
does this actually work? I'm wondering if this plays well with copybara.
There was a problem hiding this comment.
I don't know what copybara does with it in the GitHub -> google3 direction, but Ivo has been adding a bunch of these comments lately, so I would expect them to work at least if you fix them up during import.
...ava/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
Outdated
Show resolved
Hide resolved
...ava/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
Outdated
Show resolved
Hide resolved
...ava/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
Outdated
Show resolved
Hide resolved
| moduleExtensionMetadata, | ||
| repoMappingRecorder.recordedEntries()); | ||
| } catch (EvalException e) { | ||
| env.getListener().handle(Event.error(e.getMessageWithStack())); | ||
| Location innermostLocation = |
There was a problem hiding this comment.
is this a common pattern? IOW why don't we do this with other catch (EvalException e) clauses? If we should, should we create a helper method for it or something?
There was a problem hiding this comment.
I added a helper method and updated all other cases I could find. It's slightly duplicative information as the stack trace also contains locations, but this gets rid of the <builtin> and is also easier to parse and copy-paste.
...ava/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
Outdated
Show resolved
Hide resolved
Wyverald
approved these changes
Aug 22, 2024
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 7.4.0 |
github-actions
bot
removed
the
awaiting-PR-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
…23585) Fixes #19055 RELNOTES: Repository rules instantiated in the same module extensions can now refer to each other by their extension-specified names in label attributes. Closes #23369. PiperOrigin-RevId: 666893202 Change-Id: Ib2eaa55fcb563adc86e16dc4a357ac808228ebda --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19055
RELNOTES: Repository rules instantiated in the same module extensions can now refer to each other by their extension-specified names in label attributes.