Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer eagerly fetch labels in repo rule attributes #23371

Closed
wants to merge 2 commits into from

Commits on Aug 20, 2024

  1. No longer eagerly fetch labels in repo rule attributes

    Eager fetching of all labels listed in repo rule attributes as introduced as a performance optimization when to avoid restarts. Now that restarts are gone by default, this is no longer a benefit as it can cause unnecessary fetches and also create cycles where there wouldn't be any without this behavior (e.g. when two repos write each others labels into a file without resolving them).
    fmeum committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    46da85c View commit details
    Browse the repository at this point in the history
  2. Fix tests

    fmeum committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f69f0e9 View commit details
    Browse the repository at this point in the history