Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - July 2018 - name: 0.16.1 #5792

Closed
c-parsons opened this issue Aug 7, 2018 · 15 comments
Closed

Release - July 2018 - name: 0.16.1 #5792

c-parsons opened this issue Aug 7, 2018 · 15 comments
Assignees
Labels

Comments

@c-parsons
Copy link
Contributor

c-parsons commented Aug 7, 2018

Patch release on top of release 0.16.0 (#5058)

Baseline: 4f64b77

Previous Cherrypicks (for release 0.16.0):
4c9a0c8
d3228b6
8ff87c1
c4622ac
1021965
ab1f269
68e92b4
f45c224
bca1912
3842bd3

Cherrypicks so far for 0.16.1:
To fix #5777 and #5792: c4670db 1c81337 e4277c7 28dfe31 b0e8d0a
To fix #5683: 6bd0bdf f330439

Still unresolved: #5730

@c-parsons
Copy link
Contributor Author

Update: Holding off on cherrypicks for #5777, as it seems patch in #5760 might suffice. Waiting for investigation.

@meteorcloudy
Copy link
Member

Question, why would the base line commit be fb9215a instead of the original one 4f64b77? Wouldn't it introduce new commits between them?

@c-parsons
Copy link
Contributor Author

You're absolutely correct. I've edited the cherrypick list above to fix my mistake. Thanks for the notice!

@c-parsons
Copy link
Contributor Author

OK, with #5760 being fixed, the list of cherrypicks for 0.16.1 becomes:

To fix #5777 (and #5730 ?) : 366da4c c56699d 30c601d
To fix #5683: 6bd0bdf f330439

@cushon
Copy link
Contributor

cushon commented Aug 8, 2018

OK, with #5760 being fixed,

#5760 was the PR, #5744 is the bug that it fixes. Don't forget the cherry-picks for that one:

To fix #5744: 366da4c c56699d 30c601d

@c-parsons
Copy link
Contributor Author

I've generated 0.16.1rc1. (I needed to resolve several merge conflicts around JDK BUILD/bzl files, hope I did so correctly:))

https://storage.googleapis.com/bazel/0.16.1/rc1/index.html

@dslomov
Copy link
Contributor

dslomov commented Aug 9, 2018

Let's document what is the state of 0.16.1 as proposed here (roll forward fixes to enable compilation on JDK 9) w.r.t. the following issues:

(Ideally they are all fixed with @cushon's fixes for #5744)

@cushon
Copy link
Contributor

cushon commented Aug 9, 2018

@petemounce
Copy link
Contributor

rc1 and rc2 are on chocolatey

@buchgr
Copy link
Contributor

buchgr commented Aug 13, 2018

0.16.1 has been released! https://releases.bazel.build/0.16.1/release/index.html

I have sent out a patch to homebrew: Homebrew/homebrew-core#31066

cc @vbatts @oetemounce @ilovezfs

@vbatts
Copy link

vbatts commented Aug 13, 2018 via email

@petemounce
Copy link
Contributor

chocolatey is published.

@katre
Copy link
Member

katre commented Sep 11, 2018

Users are still seeing issues with JDK version in 0.16.1 (see #6072). Can we cut a 0.16.2 with the fixes needed to unblock them?

@laurentlb
Copy link
Contributor

What needs to be cherrypicked in 0.16.2 exactly?
Is it just 282b883?

@cushon @lberki @katre @davido

@davido
Copy link
Contributor

davido commented Sep 12, 2018

@laurentlb I think yes. It could be easily tested when building JGit, as described by @msohn in #6027 (comment) or following the steps from #5888.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants