-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release - August 2018 - Target RC date: 2018-08-01 - name: 0.17.0 #5059
Comments
@jin lmk if you are not available on these dates |
Can we delay cutting the release until #3115 is fixed? I'm aiming to mail a fix today |
@dkelmer if it's a regression we can also cherry pick it |
That works too. rules_go is definitely broken and I imagine other projects are too |
Using Aug 3 nightly: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/368 StatusOn hold, blocked on:
Release blockers
Also: all Windows pipelines are failing due to #5749 Ignore
BaselineTo cherrypickFor tensorflow: For rules_apple: For mainrepo changes affecting rules_go |
Pushing 0.17.0rc1
|
Pushed to chocolatey. |
Can I suggest adding a blocker for some simple migration instructions for #4502? As you can see it breaks lots of projects, and there are questions on #4502 and one on bazel-discuss about how to migrate - in particular for teams that use both |
Yes, we'll make sure there are migration instructions in the release notes.
Is there somewhere else you think we should add instructions?
…On Tue, Aug 7, 2018 at 9:25 AM Rodrigo Queiro ***@***.***> wrote:
Can I suggest adding a blocker for some simple migration instructions for
#4502 <#4502>? As you can see
it breaks lots of projects, and there are questions on #4502
<#4502> and one on bazel-discuss
<https://groups.google.com/forum/?pli=1#!topic/bazel-discuss/IWEA7npKNYg>
about how to migrate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5059 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGPQ46s-l0U6dQFdmn9nfrDLS9XHpRKsks5uOZVGgaJpZM4TbvBB>
.
|
@jin I think due to the regressions in the 0.16.0 release regarding the embedded JDK and Java rules we'll need to put the 0.17.0 release on hold for now. |
@buchgr will do - thanks for the update. |
@cvcal I guess there's a chicken/egg problem, but it would be ideal to link them from the warning. Otherwise a noticeable mention in the release notes seems sufficient. PS. The warning is not colored for me, so it doesn't stand out so much from the stdout-spam[1], is that expected? [1]: I have, to my great shame, failed to stop this building up in our project. |
Unfortunately, yes - the warning is printed from the C++ client, not the server, which is where the colored lines come from. I know this makes it less noticeable, and that's sad... |
No problem, thanks for the clarification. Maybe other people have cleaner
builds :)
Thanks for being so responsive the whole way through on this change by the
way!
|
As of @dslomov's email in https://groups.google.com/forum/#!topic/bazel-discuss/1116GHzkNm0, we'll put 0.17.0 on hold until we cut a new 0.16.1 release with the fixes to the embedded JDK 9. |
We are expecting to release 0.16.1 on Monday, 13th August based on this release candidate https://releases.bazel.build/0.16.1/rc2/index.html |
It seems that Gerrit cannot be built any more on JDK9 on 0.17.0rc1 and master, see #5896. |
Reassigning to the new release team @aehlig @philwo @katre @laurentlb |
What is the current state of 0.17? I see that 0.16.1 has been released (https://github.com/bazelbuild/bazel/releases). I can cut a new 0.17, with the same baseline and cherrypick as https://releases.bazel.build/0.17.0/rc1/index.html. On top of that, I can also cherrypick everything that went into 0.16.1. Is that correct? |
Was it intended to create a 0.17.1 RC release? I expected a 0.17.0 RC3. 😄 |
Yes. 0.17.0 was abandoned, 0.17.1 was created using a different baseline. |
Done, 9323c57 added. I think all known issues have been fixed. If nothing new is reported, we should release this week. |
Please also cherry pick 1aba9ac. Envoy build breaks without it. |
FYI- I think #6121 will be a release blocker but I just filed it so obviously no one triaged it yet. |
RCs 2, 3, 4, 5 all published to chocolatey. |
@laurentlb There is another release blocker: Gerrit cannot be built on Java 9 any more: #6127. There is no fix available yet. |
@laurentlb @lberki the fix for #6127 was submitted as 2579b79 |
Should I delay the release again, or can we use this commit in a patch release? |
Cherrypicked both 2579b79 and 2834613. https://releases.bazel.build/0.17.1/rc7/index.html |
In the release notes, are the second and third accurate?
|
I think so. The draft release announcement is here: https://docs.google.com/document/d/1wDvulLlj4NAlPZamdlEVFORks3YXJonCjyuQMUQEmB0/edit#heading=h.fdnt5bpp42hj (we don't update the generated release notes, so they sometimes have issues) |
@laurentlb any idea if we'll have a release today/tomorrow or not? |
I plan to release it tomorrow morning. Sorry for the delays |
Released: https://github.com/bazelbuild/bazel/releases/tag/0.17.1 The announcement will be published on the website later today. |
@laurentlb ilovezfs is no longer doing homebrew. as mentioned in the release guide you need to update our own homebrew tap: https://github.com/bazelbuild/homebrew-tap |
Pushed to chocolatey. |
@laurentlb It looks like we need to make a 0.17.2 point release containing 2e677fb Brief summary: 0.17 introduces a regression where Android apps can't be built at the desugaring step when used in conjunction with a manual Please see #6159 (comment) for more details. cc @cushon |
@steeve unfortunately the cherrypick policy doesn't cover that. |
Please use the new bug for discussing cherrypick requests (#6164). |
No description provided.
The text was updated successfully, but these errors were encountered: