setup: Upgrade to bazel 0.16.1 on Ubuntu #9212
Conversation
|
@drake-jenkins-bot linux-xenial-unprovisioned-clang-cmake-experimental please |
|
@drake-jenkins-bot linux-xenial-unprovisioned-clang-bazel-experimental please |
|
\CC @SeanCurtis-TRI FYI -- in case you want to do any local CLion testing. I've myself tested the CLion-related revisions posted here, albeit only for 10 minutes. |
There was a problem hiding this comment.
Thanks for the FYI. I trust your 10 minutes; it seems incredible that something catastrophic would happen.
Reviewable status: all discussions resolved, platform LGTM missing
|
+@jamiesnape for feature review, please. This PR does not update the macOS supported version, or the WORKSPACE and CMakeLists.txt enforced minimum version. It seems like we should leave those alone until homebrew catches up. |
There was a problem hiding this comment.
It seems like we should leave those alone until homebrew catches up.
I'm watching the related PR: Homebrew/homebrew-core#30653
Reviewed 4 of 4 files at r1.
Reviewable status: all discussions resolved, LGTM missing from assignee jamiesnape, platform LGTM from [soonho-tri]
|
I think we should wait for a resolution of bazelbuild/bazel#5753. That along with bazelbuild/bazel#5744 suggests the release did not go to plan again (the release that should have an embedded JDK did not, the one that should not have one did). |
There was a problem hiding this comment.
Fine by me. I've subscribed to those issues; I'll refresh this PR to use 0.16.1 once its released.
Reviewable status: all discussions resolved, LGTM missing from assignee jamiesnape, platform LGTM from [soonho-tri]
|
Note we will need to bump to Java 9 on Mac (Linux looks like it will be using an embedded JDK). |
There was a problem hiding this comment.
I've updated this PR to propose 0.16.1 for Ubuntu. PTAL.
Homebrew has some substantial changes to install and release instructions pending for bazel; I'd like to still bump Ubuntu to a newer version on Ubuntu even if macOS isn't ready yet.
Reviewable status: all discussions resolved, LGTM missing from assignee jamiesnape, platform LGTM from [soonho-tri], labeled "do not merge"
|
@drake-jenkins-bot linux-xenial-unprovisioned-clang-cmake-experimental please |
There was a problem hiding this comment.
Reviewable status: all discussions resolved, LGTM missing from assignee jamiesnape, platform LGTM from [soonho-tri], labeled "do not merge"
doc/clion.rst, line 57 at r2 (raw file):
- CLion 2018.1.6 - Bazel 0.16.1 - "CLion with Bazel" plug-in 2018.06.11.0.3.
BTW this combination resulted in red symbols in CLion on my new Puget. @amcastro-tri says Mengyao had the same problem on her new laptop. I had to back off to CLion 2017.3.4 (w/matching plugin) to get all symbols working. I did upgrade to Bazel 0.16.1 with no trouble though and it works with 2017.3.4.
OTOH my old laptop upgraded to 2018.1.6 with no problems. Currently I think we have a problem for new installations but something leftover from old installations allows the new CLion to find the symbols.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status: all discussions resolved, LGTM missing from assignee jamiesnape, platform LGTM from [soonho-tri], labeled "do not merge"
jwnimmer-tri
changed the title
There was a problem hiding this comment.
Reviewable status: all discussions resolved, LGTM missing from assignee jamiesnape, platform LGTM from [soonho-tri], labeled "do not merge"
doc/clion.rst, line 57 at r2 (raw file):
Previously, sherm1 (Michael Sherman) wrote…
BTW this combination resulted in red symbols in CLion on my new Puget. @amcastro-tri says Mengyao had the same problem on her new laptop. I had to back off to CLion 2017.3.4 (w/matching plugin) to get all symbols working. I did upgrade to Bazel 0.16.1 with no trouble though and it works with 2017.3.4.
OTOH my old laptop upgraded to 2018.1.6 with no problems. Currently I think we have a problem for new installations but something leftover from old installations allows the new CLion to find the symbols.
OK If tools are not working, people who are experiencing trouble should open an issue and document the details so that we can work on it.
|
@jamiesnape What do you think? Either we do this today, or we defer until after labor day. |
There was a problem hiding this comment.
Let's bump Bazel on Mac to 0.15.2 and CMake on Mac to 3.12.1 while we are here (since we are all basically using that anyway) and then merge. I think Bazel 0.16.x is going to be a lost cause on Mac.
Reviewed 4 of 4 files at r2.
Reviewable status: all discussions resolved, platform LGTM from [soonho-tri], labeled "do not merge"
|
Sure. I'll do that in a new PR though, to avoid a CI delay here. I'll file it this morning. |
|
Sounds good. |
This change is