Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More dialyzer fixes. #552

Merged
merged 46 commits into from
Mar 4, 2014
Merged

More dialyzer fixes. #552

merged 46 commits into from
Mar 4, 2014

Conversation

cmeiklejohn
Copy link
Contributor

Fix a bunch of additional dialyzer errors, @seancribbs.

@cmeiklejohn
Ignore the result of the list comprehension.
46a899d 
Resolves:

bounded_queue.erl:60: Expression produces a value of type [any()], but this value is unmatched
bounded_queue.erl:71: Expression produces a value of type [any()], but this value is unmatched
@cmeiklejohn
Ignore the result of the tcp send.
e2c8292 
Resolves:

riak_repl_keylist_server.erl:146: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:149: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:190: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:202: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:211: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:238: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:244: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:322: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:344: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:380: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:389: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:411: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:470: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:517: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_server.erl:538: Expression produces a value of type ['ok' | {'error',_}], but this value is unmatched
riak_repl_keylist_client.erl:183: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_client.erl:273: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_client.erl:238: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_client.erl:239: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_repl_keylist_client.erl:250: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
@cmeiklejohn
Bump tools.mk.
42e47a8
@cmeiklejohn
Ignore unset_env and set_env calls which take tuples.
b5f928a
@cmeiklejohn
Ignore the result of file calls.
77e11d0 
Ignore the result.  However, we technically should be doing strict
matches on the calls, but given we don't know if all of these are
currently succeeding we can't validate the change without proper test
coverage.

Resolves:

riak_repl_keylist_server.erl:191: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:229: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:234: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:235: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:255: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:262: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:265: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:266: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_client.erl:104: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_client.erl:211: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_client.erl:212: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_client.erl:248: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_client.erl:249: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:191: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:229: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:234: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:235: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:255: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:262: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:265: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_keylist_server.erl:266: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:307: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched'
riak_repl_fullsync_helper.erl:228: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:235: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:91: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:92: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:205: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:206: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:209: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:210: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:224: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:228: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:293: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
riak_repl_fullsync_helper.erl:301: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
@cmeiklejohn
Ignore result of the list comprehension.
c9f561b 
Resolves:

riak_repl_fullsync_worker.erl:160: Expression produces a value of type [any()], but this value is unmatched
@cmeiklejohn
Ignore list comprehension result.
db9885b 
Resolves:

riak_repl_fullsync_worker.erl:53: Expression produces a value of type ['ok' | {'error',_}], but this value is unmatched
@cmeiklejohn
Ignore dialyzer output files.
9f26ee8
@cmeiklejohn
Ignore return value from call.
1daa140 
Resolves:

riak_repl_keylist_server.erl:531: Expression produces a value of type 'ok' | 'skipped' | {'error',_}, but this value is unmatched
@cmeiklejohn
Ignore result of the multicall.
77a3b7a 
Resolves:

gen_leader.erl:436: Expression produces a value of type 'nop' | {[any()],[atom()]}, but this value is unmatched
@cmeiklejohn
Ignore result of timer cancellation.
26382f7 
Resolves:

gen_leader.erl:513: Expression produces a value of type {'error',_} | {'ok','cancel'}, but this value is unmatched
@cmeiklejohn
Normalize return value.
8cac9e6 
Resolves:

riak_repl_keylist_server.erl:370: Expression produces a value of type 'ok' | {_,'diff_resume'}, but this value is unmatched
@cmeiklejohn
Ignore result of the supervisor calls.
2a3ecc5 
Resolves:

riak_repl_client_sup.erl:18: Expression produces a value of type 'ok' | {'error','not_found' | 'simple_one_for_one'}, but this value is unmatched
@cmeiklejohn
Fix typo in type specification.
677a30d 
Resolves:

riak_repl_cs.erl:127: Invalid type specification for function riak_repl_cs:bool_to_ok_or_cancel/1. The success typing is (boolean()) -> 'cancel' | 'ok'
@cmeiklejohn
Ignore the result of the list comprehension.
521ee4f 
riak_repl_console.erl:470: Expression produces a value of type ['ok'], but this value is unmatched
@cmeiklejohn
Ignore result of supervisor call.
7f64210 
Resolves:

riak_repl_console.erl:441: Expression produces a value of type 'ok' | {'error','not_found' | 'restarting' | 'running' | 'simple_one_for_one'}, but this value is unmatched
@cmeiklejohn
Refactor the queue_handoff call.
b9edb29 
Inline, and stop making look like a gen_server call.

Resolves:

riak_repl_migration.erl:53: Expression produces a value of type {'reply','error' | 'ok',#state{}}, but this value is unmatched
@cmeiklejohn
Ignore callback function warnings.
ee4c013
@cmeiklejohn
Ignore result of list comprehensions.
ce0d30f 
Resolves:

riak_repl_console.erl:416: Expression produces a value of type [any()], but this value is unmatched
@cmeiklejohn
Ignore result of list comprehensions.
816f98b 
Resolves:

riak_repl_console.erl:416: Expression produces a value of type [any()], but this value is unmatched
riak_repl_client_sup.erl:47: Expression produces a value of type [{'error',_} | {'ok','undefined' | pid()} | {'ok','undefined' | pid(),_}], but this value is unmatched
riak_repl_client_sup.erl:48: Expression produces a value of type ['ok' | {'error','not_found' | 'restarting' | 'running' | 'simple_one_for_one'}], but this value is unmatched
@cmeiklejohn
Ignore result of supervisor call.
78276b5 
Resolves:

riak_repl_console.erl:435: Expression produces a value of type {'error',_} | {'ok','undefined' | pid()} | {'ok','undefined' | pid(),_}, but this value is unmatched
@cmeiklejohn
Ignore result of timer cancellation.
64a6a55 
Resolves:

gen_leader.erl:586: Expression produces a value of type {'error',_} | {'ok','cancel'}, but this value is unmatched
@cmeiklejohn
Ignore return value of list comprehension.
097c181 
Resolves:

gen_leader.erl:597: Expression produces a value of type [{'heartbeat',atom()}], but this value is unmatched
gen_leader.erl:814: Expression produces a value of type [{'checklead',atom()}], but this value is unmatched
@cmeiklejohn
Ignore result of timer calls.
e129760 
Resolves:

gen_leader.erl:816: Expression produces a value of type {'error',_} | {'ok',timer:tref()}, but this value is unmatched
gen_leader.erl:847: Expression produces a value of type {'error',_} | {'ok','cancel'}, but this value is unmatched
@cmeiklejohn
Normalize return value.
fc51e72 
Resolves:

gen_leader.erl:611: Expression produces a value of type 'ok' | {'heartbeat',pid()}, but this value is unmatched
@cmeiklejohn
Ignore result of timer calls.
329af7e 
Resolves:

gen_leader.erl:1127: Expression produces a value of type {'error',_} | {'ok','cancel'}, but this value is unmatched
gen_leader.erl:1344: Expression produces a value of type {'error',_} | {'ok',timer:tref()}, but this value is unmatched
@cmeiklejohn
Ignore the result of sending on the socket.
f070c4e 
Resolves:

riak_repl_bq.erl:118: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
@cmeiklejohn
Ignore return value of the comprehension.
9627d79 
Resolves:

riak_repl_app.erl:93: Expression produces a value of type [any()], but this value is unmatched
@cmeiklejohn
Normalize and ignore return value.
bd712ac 
Resolves:

riak_repl_app.erl:135: Expression produces a value of type 'ignore' | [string()], but this value is unmatched
@cmeiklejohn
Remove manual ssl:start() calls.
5964cd7 
At this point, the ssl application will already be started because it is
a dependency of the riak_repl application.

Resolves:

riak_core_service_mgr.erl:305: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
riak_core_service_mgr.erl:347: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
@cmeiklejohn
Ignore result of list comprehension.
2306345 
Resolves:

riak_core_service_mgr.erl:247: Expression produces a value of type [any()], but this value is unmatched
@cmeiklejohn
Ignore result of the call.
2dc7697 
Resolves:

riak_repl_aae_source.erl:336: Expression produces a value of type 'ok' | pid(), but this value is unmatched
@cmeiklejohn
Ignore result; normalize return.
b9b974f 
We never consume the result of the send after call; normalize return.

Resolves:

riak_core_cluster_mgr.erl:306: Expression produces a value of type 'ok' | reference(), but this value is unmatched
@cmeiklejohn
Ignore result of return.
75f5d8b 
Resolves:

riak_core_cluster_mgr.erl:323: Expression produces a value of type 'ok' | {'error',_} | {'ok','undefined' | pid()} | {'ok','undefined' | pid(),_}, but this value is unmatched
@cmeiklejohn
Ignore return value of comprehension.
5f317ea 
Resolves:

riak_core_cluster_mgr.erl:380: Expression produces a value of type [{pid(),'poll_cluster'}], but this value is unmatched
@cmeiklejohn
Normalize return value.
5ed0d04 
Considering there are no direct consumers of this methods return value,
normalize it to always return ok.

Resolves:

riak_core_cluster_mgr.erl:613: Expression produces a value of type 'ok' | {'error',_} | {'ok','undefined' | pid()} | {'ok','undefined' | pid(),_}, but this value is unmatched
riak_core_cluster_mgr.erl:544: Expression produces a value of type 'ok' | {'error',_} | {'ok','undefined' | pid()} | {'ok','undefined' | pid(),_}, but this value is unmatched
riak_core_cluster_mgr.erl:551: Expression produces a value of type 'ok' | {'error',_} | {'ok','undefined' | pid()} | {'ok','undefined' | pid(),_}, but this value is unmatched
@cmeiklejohn
Ignore return value of connections call.
74df1c7 
Resolves:

riak_core_cluster_mgr.erl:691: Expression produces a value of type 'ok' | ['ok'], but this value is unmatched
@cmeiklejohn
Match on ets table name.
926dc09 
Resolves:

riak_repl2_rtq.erl:108: Expression produces a value of type atom() | tid(), but this value is unmatched
@cmeiklejohn
Match error case correctly.
6467dc1 
When lists:keytake fails, it returns false, not error.

Resolves:

riak_core_service_mgr.erl:258: The pattern 'error' can never match the type 'false' | {'value',tuple(),[tuple()]}
@cmeiklejohn
Ignore return value of the ranch call.
e389583 
Resolves:

riak_core_service_mgr.erl:183: Expression produces a value of type 'ok' | {'error','not_found'}, but this value is unmatched
@cmeiklejohn
Ignore return value of the setopts call.
b9437fd 
Resolves:

riak_core_connection.erl:144: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
@seancribbs seancribbs self-assigned this Mar 4, 2014
@cmeiklejohn
Copy link
Contributor Author

I think I addressed everything, is this 👍 to merge, @seancribbs?

@seancribbs
Copy link

Yep, 👍 to merge

cmeiklejohn added a commit that referenced this pull request Mar 4, 2014
@cmeiklejohn
Merge pull request #552 from basho/features/csm/dialyzer
7e40cd6 
More dialyzer fixes.
@cmeiklejohn cmeiklejohn merged commit 7e40cd6 into develop Mar 4, 2014
@cmeiklejohn cmeiklejohn deleted the features/csm/dialyzer branch March 4, 2014 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmeiklejohn @seancribbs @Vagabond @reiddraper