Skip to content

Commit

Permalink
Ignore return value from call.
Browse files Browse the repository at this point in the history
Resolves:

riak_repl_keylist_server.erl:531: Expression produces a value of type 'ok' | 'skipped' | {'error',_}, but this value is unmatched
  • Loading branch information
cmeiklejohn committed Mar 3, 2014
1 parent 9f26ee8 commit 1daa140
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/riak_repl_keylist_server.erl
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ diff_bloom({Ref,diff_exchanged}, #state{diff_ref=Ref} = State) ->
%% server <- bloom_fold : diff_obj 'recv a diff object from bloom folder
diff_bloom({diff_obj, RObj}, _From, #state{client=Client, transport=Transport,
socket=Socket, proto=Proto} = State) ->
case riak_repl_util:maybe_send(RObj, Client, Proto) of
_ = case riak_repl_util:maybe_send(RObj, Client, Proto) of

This comment has been minimized.

Copy link
@seancribbs

seancribbs Mar 4, 2014

Could this be simplified by having each case clause return 'ok'?

This comment has been minimized.

Copy link
@cmeiklejohn

cmeiklejohn Mar 4, 2014

Author Contributor

Yes, it can. I didn't realize that no one was consuming the result of this call. Pushed badbf78 to address.

cancel ->
skipped;
Objects when is_list(Objects) ->
Expand Down

0 comments on commit 1daa140

Please sign in to comment.