-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ignore return value of the setopts call.
Resolves: riak_core_connection.erl:144: Expression produces a value of type 'ok' | {'error',atom()}, but this value is unmatched
- Loading branch information
1 parent
e389583
commit b9437fd
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,7 +141,7 @@ sync_connect_status(_Parent, {IP,Port}, {ClientProtocol, {Options, Module, Args} | |
case gen_tcp:connect(IP, Port, ?CONNECT_OPTIONS, Timeout) of | ||
{ok, Socket} -> | ||
lager:debug("Setting system options on client side: ~p", [?CONNECT_OPTIONS]), | ||
Transport:setopts(Socket, ?CONNECT_OPTIONS), | ||
_ = Transport:setopts(Socket, ?CONNECT_OPTIONS), | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
cmeiklejohn
Author
Contributor
|
||
SSLEnabled = app_helper:get_env(riak_core, ssl_enabled, false), | ||
%% handshake to make sure it's a riak sub-protocol dispatcher | ||
MyName = symbolic_clustername(), | ||
|
I wonder is this safe? Should you start up with a connection that has bad options, assuming that specific behaviors are actually in-use? I realize the options are a macro and are probably all valid, but if someone changes them in the future...this code would not crash.