Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ValidatorSet] Expose/Unexpose config methods #80

Merged
merged 2 commits into from
Nov 13, 2022
Merged

[ValidatorSet] Expose/Unexpose config methods #80

merged 2 commits into from
Nov 13, 2022

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Nov 11, 2022

Description

  1. Exposing methods as comment in Function issues: naming, exposing and params #50.
  2. Unexposing setNumberOfBlocksInEpoch method

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao mentioned this pull request Nov 11, 2022
Closed
3 tasks
@nxqbao nxqbao marked this pull request as ready for review November 11, 2022 11:30
@nxqbao nxqbao linked an issue Nov 11, 2022 that may be closed by this pull request
Function issues: naming, exposing and params #50
Closed
@nxqbao nxqbao merged commit 0e41ce2 into main Nov 13, 2022
@nxqbao nxqbao deleted the refactor/unexpose-config-method-in-ronin-validator-set branch November 13, 2022 09:27
@ducthotran2010 ducthotran2010 mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducthotran2010 ducthotran2010 ducthotran2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function issues: naming, exposing and params
2 participants
@nxqbao @ducthotran2010