Function issues: naming, exposing and params

[ducthotran2010]

ronin-dpos-contracts/contracts/ronin/validator/RoninValidatorSet.sol

Line 821 in 2ef51c7

function _setPrioritizedValidatorNumber(uint256 _number) internal {

    I can't see public corresponding function of this.

Originally posted by @minh-bq in #22 (comment)

[ducthotran2010]

ronin-dpos-contracts/contracts/ronin/validator/RoninValidatorSet.sol

Line 293 in 2ef51c7

function bulkJailed(address[] memory _addrList) external view override returns (bool[] memory _result) {

ronin-dpos-contracts/contracts/ronin/validator/RoninValidatorSet.sol

Line 319 in 2ef51c7

function miningRewardDeprecatedAtPeriod(address[] memory _blockProducers, uint256 _period)

The memory params can be set to calldata to save gas

[ducthotran2010]

      I can't see public corresponding function of this.

Originally posted by @minh-bq in #22 (comment)

ronin-dpos-contracts/contracts/ronin/StakingVesting.sol

Lines 99 to 119 in 2ef51c7

	/**
	* @dev Sets the bonus amount per block for block producer.
	*
	* Emits the event `BlockProducerBonusPerBlockUpdated`.
	*
	*/
	function _setBlockProducerBonusPerBlock(uint256 _amount) internal {
	_blockProducerBonusPerBlock = _amount;
	emit BlockProducerBonusPerBlockUpdated(_amount);
	}
	/**
	* @dev Sets the bonus amount per block for bridge operator.
	*
	* Emits the event `BridgeOperatorBonusPerBlockUpdated`.
	*
	*/
	function _setBridgeOperatorBonusPerBlock(uint256 _amount) internal {
	_bridgeOperatorBonusPerBlock = _amount;
	emit BridgeOperatorBonusPerBlockUpdated(_amount);
	}

[ducthotran2010]

ronin-dpos-contracts/contracts/ronin/staking/Staking.sol

Line 96 in 2ef51c7

function deductStakedAmount(address _consensusAddr, uint256 _amount) public onlyValidatorContract {

The public key can be set to external since no function in the contract call it #22 (comment)

[ducthotran2010]

Since we have some functions proceeding the pool in batch, we should indicate the specific pool that is not exist. We could use string.concat() for adding the address of pool in the revert message.

Originally posted by @nxqbao in #22 (comment)

ronin-dpos-contracts/contracts/ronin/staking/StakingManager.sol

Line 38 in 2ef51c7

require(_validatorContract.isValidatorCandidate(_poolAddr), "StakingManager: query for non-existent pool");

Suggestion: Using String lib from OZ
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/7201e6707f6631d9499a569f492870ebdd4133cf/contracts/utils/Strings.sol#L64-L69

    if(!_validatorContract.isValidatorCandidate(_poolAddr)) {
      revert(string(abi.encodePacked(
        "StakingManager: query for non-existent pool ",
        Strings.toHexString(_poolAddr)
      )));
    }

[ducthotran2010]

Naming issues posted by @nxqbao:

1. Internal Audit #22 (comment)
2. Internal Audit #22 (comment)
3. Internal Audit #22 (comment)

[ducthotran2010]

  function _beforeClaimReward(address _poolAddr, address _user) internal returns (uint256 _amount) {

Originally posted by @ducthotran2010 in #22 (comment)

ronin-dpos-contracts/contracts/ronin/staking/RewardCalculation.sol

Line 123 in a11290d

function _claimReward(address _poolAddr, address _user) internal returns (uint256 _amount) {