Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ValidatorSet] Restructure code base #79

Closed
wants to merge 6 commits into from
Closed

[ValidatorSet] Restructure code base #79

wants to merge 6 commits into from

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Nov 11, 2022 •
edited
Loading

Description

Split RoninValidatorSet into:

  • BaseRoninValidatorSet
  • RoninValidatorSetCommon
  • RoninValidatorSetCoinbase and RoninValidatorSetCoinbaseHelper
  • RoninValidatorSetSlashing

This PR is based on #80.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao marked this pull request as ready for review November 11, 2022 11:30
@nxqbao nxqbao changed the title Restructure validator set [ValidatorSet] Restructure code base Nov 11, 2022
@nxqbao nxqbao marked this pull request as draft November 11, 2022 16:50
@nxqbao
Copy link
Contributor Author

nxqbao commented Nov 15, 2022

Retry in #87.

@nxqbao nxqbao closed this Nov 15, 2022
@ducthotran2010 ducthotran2010 deleted the refactor/restructure-validator-set branch November 21, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nxqbao