Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bedrock): adopt best practices #750

Closed
wants to merge 10 commits into from

Conversation

aws-rafams
Copy link
Contributor

Fixes #733

There is an integ test that I can remove after it has been tested.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

aws-rafams and others added 10 commits October 9, 2024 10:14
* chore(documentation): update readme to fix issues
…mmarization-appsync-stepfn construct (awslabs#722)

* feat(content-gen): update modelid in content gen construct
---------

Co-authored-by: Dinesh Sajwan <dinsajwa@amazon.com>
Co-authored-by: Alain Krok <alkrok@amazon.com>
Upgrade list of models and DLC images. See details in [workflow run].
[Workflow Run]: https://github.com/awslabs/generative-ai-cdk-constructs/actions/runs/11283958742
------
*Automatically created by projen via the "code-generation" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrade list of models and DLC images. See details in [workflow run].
[Workflow Run]: https://github.com/awslabs/generative-ai-cdk-constructs/actions/runs/11318853147
------
*Automatically created by projen via the "code-generation" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Upgrade list of models and DLC images. See details in [workflow run].
[Workflow Run]: https://github.com/awslabs/generative-ai-cdk-constructs/actions/runs/11336903352
------
*Automatically created by projen via the "code-generation" workflow*

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
@aws-rafams aws-rafams requested a review from a team as a code owner October 15, 2024 11:13
@aws-rafams aws-rafams changed the title refactor(bedrock): adopt best practices fix(bedrock): adopt best practices Oct 15, 2024
@krokoko
Copy link
Collaborator

krokoko commented Oct 15, 2024

Thanks @aws-rafams ! I see some changes not related to this PR in your files (seems to be previous commits), could you please fix the conflicts and merge main back ? I think this should fix it, will review after. Thanks !

@aws-rafams
Copy link
Contributor Author

Closing this in favour of #751

@aws-rafams aws-rafams closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bedrock): guardrails - module refactoring to follow best practices from CDK
4 participants