-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bedrock): adopt best practices #751
Conversation
Thanks @aws-rafams ! Did a first pass and looks good to me overall. Left one comment about type aliasing. |
First results from testing in TS:
The agent is correctly created, as well as the guardrails Guardrails are correctly working (permissions are correctly applied):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aws-rafams ! Overall it is good, I tested in both TS and Python
Fixed a readme issue and added Python code snippets
Only blocking issue is the GuardrailSampleTopics
which doesn't seem to be exported correctly In Python (cannot access it). It is working fine in Ts. Once fixed, I will approve.
My other comments are non blocking, and could be some work part of a subsequent PR.
Thank you !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in both Ts and Py following recent changes:
- Sample Topics are exported correctly, tested to create and add to guardrails
- Create guardrails using the constructor and attach them to an agent
- Create CfnGuardrail using the L1 CDK construct, import them using fromCfnGuardrail and attach it to an agent
- Create guardrails through the console, import them using fromGuardrailAttributes and attach it to an agent
Every scenario was working as expected. Thanks @aws-rafams , great job !
Fixes #733
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.