-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(construct): Bug fix for aws-contentgen-appsync-lambda and aws-summarization-appsync-stepfn construct #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshSajwan
requested review from
krokoko,
MichaelWalker-git and
alexa-perlov
October 1, 2024 19:27
dineshSajwan
changed the title
feat(construct): update model id in aws-contentgen-appsync-lambda construct.
feat(construct): Bug fix for aws-contentgen-appsync-lambda and aws-summarization-appsync-stepfn construct
Oct 4, 2024
krokoko
reviewed
Oct 4, 2024
krokoko
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, main points:
- missing license header
- buid failed on mutation
Once fixed will approve :)
krokoko
approved these changes
Oct 4, 2024
scottschreckengaust
approved these changes
Oct 7, 2024
aws-rafams
pushed a commit
to aws-rafams/generative-ai-cdk-constructs
that referenced
this pull request
Oct 15, 2024
…mmarization-appsync-stepfn construct (awslabs#722) * feat(content-gen): update modelid in content gen construct --------- Co-authored-by: Dinesh Sajwan <dinsajwa@amazon.com> Co-authored-by: Alain Krok <alkrok@amazon.com>
dineshSajwan
added a commit
that referenced
this pull request
Oct 17, 2024
…mmarization-appsync-stepfn construct (#722) * feat(content-gen): update modelid in content gen construct --------- Co-authored-by: Dinesh Sajwan <dinsajwa@amazon.com> Co-authored-by: Alain Krok <alkrok@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.