Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(construct): Bug fix for aws-contentgen-appsync-lambda and aws-summarization-appsync-stepfn construct #722

Merged
merged 14 commits into from
Oct 7, 2024

Conversation

dineshSajwan
Copy link
Contributor

@dineshSajwan dineshSajwan commented Oct 1, 2024

Fixes #

  • update model id in aws-contentgen-appsync-lambda.
  • update lambda subnet to private_with_egress
  • update summarization construct to check for existing log group
  • removed custom bucket names from summarization construct to avoid name conflict with multiple deployments

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@dineshSajwan dineshSajwan changed the title feat(construct): update model id in aws-contentgen-appsync-lambda construct. feat(construct): Bug fix for aws-contentgen-appsync-lambda and aws-summarization-appsync-stepfn construct Oct 4, 2024
@krokoko krokoko self-requested a review October 4, 2024 16:30
Copy link
Collaborator

@krokoko krokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, main points:

  • missing license header
  • buid failed on mutation
    Once fixed will approve :)

@krokoko krokoko self-requested a review October 4, 2024 19:23
@krokoko krokoko enabled auto-merge (squash) October 4, 2024 19:23
@krokoko krokoko merged commit 9b1b838 into awslabs:main Oct 7, 2024
14 checks passed
aws-rafams pushed a commit to aws-rafams/generative-ai-cdk-constructs that referenced this pull request Oct 15, 2024
…mmarization-appsync-stepfn construct (awslabs#722)

* feat(content-gen): update modelid in content gen construct
---------

Co-authored-by: Dinesh Sajwan <dinsajwa@amazon.com>
Co-authored-by: Alain Krok <alkrok@amazon.com>
dineshSajwan added a commit that referenced this pull request Oct 17, 2024
…mmarization-appsync-stepfn construct (#722)

* feat(content-gen): update modelid in content gen construct
---------

Co-authored-by: Dinesh Sajwan <dinsajwa@amazon.com>
Co-authored-by: Alain Krok <alkrok@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants