Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(refactor): deprecate Omnibus #4953

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Dec 5, 2024

Description of changes:

This PR deletes the buildspec_omnibus.yml file.

The s2nOmnibus CodeBuild job's coverage can be covered by individual jobs in our CI. We will run s2nGeneralBatch, Valgrind, s2nFuzzBatch, and AddressSanitizer instead to test our release in the future.

We are using some previous PRs to gradually drop s2nOmnibus coverages, and those PRs are PR#4913, PR#4945, and PR#4946. Such gradual drops of Omnibus' jobs can ensure that we are not losing any coverage along the way.

I have compared the rest of buildspec_omnibus.yml against the buildspec_generalbatch.yml, and found out that buildspec_generalbatch.yml covers all test jobs in the remaining buildspec_omnibus.yml. The release Lambda has also drop s2nOmnibus in the codebuild jobs list. Hence, we can fully deprecate the s2nOmnibus job now.

Call-outs:

  • This PR can be merged after PR#4950 is merged. Without PR#4950, s2nGeneralBatch triggered by the Lambda will failed, because of using the wrong directory.

  • The s2nOmnibus job should be removed from the Codebuild.

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* remove Omnibus buildspec
@github-actions github-actions bot added the s2n-core team label Dec 5, 2024
@boquan-fang boquan-fang marked this pull request as ready for review December 5, 2024 20:41
@boquan-fang boquan-fang requested a review from dougch as a code owner December 5, 2024 20:41
@boquan-fang boquan-fang requested a review from jmayclin December 5, 2024 20:42
@boquan-fang boquan-fang enabled auto-merge (squash) December 6, 2024 17:52
@boquan-fang boquan-fang merged commit ee391c7 into aws:main Dec 6, 2024
39 checks passed
@boquan-fang boquan-fang deleted the deprecate-omnibus branch December 18, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants