Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR deletes the
buildspec_omnibus.yml
file.The
s2nOmnibus
CodeBuild job's coverage can be covered by individual jobs in our CI. We will runs2nGeneralBatch
,Valgrind
,s2nFuzzBatch
, andAddressSanitizer
instead to test our release in the future.We are using some previous PRs to gradually drop
s2nOmnibus
coverages, and those PRs are PR#4913, PR#4945, and PR#4946. Such gradual drops of Omnibus' jobs can ensure that we are not losing any coverage along the way.I have compared the rest of
buildspec_omnibus.yml
against thebuildspec_generalbatch.yml
, and found out thatbuildspec_generalbatch.yml
covers all test jobs in the remainingbuildspec_omnibus.yml
. The release Lambda has also drops2nOmnibus
in the codebuild jobs list. Hence, we can fully deprecate thes2nOmnibus
job now.Call-outs:
This PR can be merged after PR#4950 is merged. Without PR#4950,
s2nGeneralBatch
triggered by the Lambda will failed, because of using the wrong directory.The
s2nOmnibus
job should be removed from the Codebuild.Testing:
s2nGeneralBatch
,S2nIntegrationV2Batch2
,Valgrind
,s2nFuzzBatch
, andAddressSanitizer
.s2nGeneralBatch
can provide full coverage for the rest of Omnibus.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.