ci(refactor): remove ASAN from Omnibus and GeneralBatch #4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
buildspec_sanitizer.ymlhas coverages for both ASAN and UBSAN, while the current Omnibus only has ASAN coverage for two libcryptos. We want to drop those two coverages in Omnibus and run ourAddressSanitizerjob instead. Hence, this PR drop the buildspec for those two jobs. We also remove the ASAN parts ins2nGeneralBatch, sinceAddressSanitizeralready provides coverages for those tests.Testing:
The results for the triggered Omnibus job, S2nIntegrationV2Batch2 job, Valgrind job, s2nFuzzBatch job, and AddressSanitizer job are linked to this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.