-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(refactor): remove Valgrind checks from omnibus and generalBatch #4913
ci(refactor): remove Valgrind checks from omnibus and generalBatch #4913
Conversation
A separate Valgrind test has been fully integrated into the github CI and the release CI. Therefore, Valgrind in generalBatch and Omnibus should be removed.
delete Valgrind sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just want to see one attempt to run this new Omnibus, we can sync up tomorrow (or add a link to the overview)
I have attached the links for triggered Omnibus, Valgrind, and Integration tests to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I would recommend getting Doug's approval on this. I'm pretty sure only he can verify the source of truth for the buildspec_omnibus.
* remove S2N_NO_PQ variable from Omnibus
Description of changes:
Our CIs for github and release runs Valgrind in
generalBatch/Omnibus
andValgrind Codebuild job
. Since a separate Valgrind test has been fully integrated into the github CI and the release CI, Valgrind in generalBatch and Omnibus should be removed.buildspec_omnibus.yml
andbuildspec_generalbatch.yml
.Makefile
s ands2n_codebuild.sh
.Call-outs:
s2nOmnibus
job's inline buildspec is out of date frombuildspec_omnibus.yml
. I synced the inline buildspec fors2nOmnibus
tobuildspec_omnibus.yml
to make them consistent.s2nOmnibus
job takes in line buildspec. I need to manually copy and pastebuildspec_omnibus.yml
to the Codebuild job after this PR is merged.Testing:
Test by CI for the refactored
GeneralBatch
job.Test for this refactored
buildspec_omnibus.yml
can be found in this codebuild job.The triggered Valgrind job can be found here.
The triggered
S2nIntegrationV2Batch2
test can be found in this job.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.