Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(refactor): remove Valgrind checks from omnibus and generalBatch #4913

Merged

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Nov 19, 2024

Description of changes:

Our CIs for github and release runs Valgrind in generalBatch/Omnibus and Valgrind Codebuild job. Since a separate Valgrind test has been fully integrated into the github CI and the release CI, Valgrind in generalBatch and Omnibus should be removed.

  • Remove buildspecs for Valgrind tests in buildspec_omnibus.yml and buildspec_generalbatch.yml.
  • Remove Valgrind in Makefiles and s2n_codebuild.sh.

Call-outs:

  • This is a follow up PR for PR#4912.
    • This PR can be merged after the previous PR is merged.
  • The s2nOmnibus job's inline buildspec is out of date from buildspec_omnibus.yml. I synced the inline buildspec for s2nOmnibus to buildspec_omnibus.yml to make them consistent.
  • Our s2nOmnibus job takes in line buildspec. I need to manually copy and paste buildspec_omnibus.yml to the Codebuild job after this PR is merged.

Testing:

Test by CI for the refactored GeneralBatch job.

Test for this refactored buildspec_omnibus.yml can be found in this codebuild job.

The triggered Valgrind job can be found here.

The triggered S2nIntegrationV2Batch2 test can be found in this job.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

A separate Valgrind test has been fully integrated into the github CI
and the release CI. Therefore, Valgrind in generalBatch and Omnibus
should be removed.
@github-actions github-actions bot added the s2n-core team label Nov 19, 2024
@boquan-fang boquan-fang marked this pull request as ready for review November 19, 2024 22:18
@boquan-fang boquan-fang requested a review from dougch as a code owner November 19, 2024 22:18
Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just want to see one attempt to run this new Omnibus, we can sync up tomorrow (or add a link to the overview)

@boquan-fang
Copy link
Contributor Author

I have attached the links for triggered Omnibus, Valgrind, and Integration tests to the Testing section of the PR descriptions.

Copy link
Contributor

@maddeleine maddeleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I would recommend getting Doug's approval on this. I'm pretty sure only he can verify the source of truth for the buildspec_omnibus.

Boquan Fang and others added 2 commits December 2, 2024 19:37
@boquan-fang boquan-fang enabled auto-merge (squash) December 2, 2024 20:46
@boquan-fang boquan-fang merged commit 91d6f1f into aws:main Dec 3, 2024
38 checks passed
@boquan-fang boquan-fang deleted the remove-valgrind-from-omnibus-generalbatch branch December 18, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants