Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix Improvements #3841

Closed
4 of 14 tasks
harrisonkaiser opened this issue Feb 20, 2023 · 1 comment · Fixed by #4567
Closed
4 of 14 tasks

Nix Improvements #3841

harrisonkaiser opened this issue Feb 20, 2023 · 1 comment · Fixed by #4567
Assignees

Comments

@harrisonkaiser
Copy link
Contributor

harrisonkaiser commented Feb 20, 2023

Problem:

With #3824 merged, there are several open problems that need addressing

Not all integ tests run in the dev shell for all platforms

  • cross_compatibility. This depends on s2nc_head and s2nd_head, which we don't provide, yet.
  • renegotiate_apache. Translate apache2 to apachectl (nix can do the apache config)
  • sslyze is only available on x86 with <python3.11, (affecting other upgrade efforts)

Tests that are flaky on arm

  • happy_path
  • ocsp
  • record_padding
  • renegotiate
  • session_resumption
  • signature_algorithms
  • version_negotiation

Not all integ tests work on arm

  • Use pytest to retry flaky tests
  • Root cause the failures and iterate on addressing the issues
  • Add aws-lc with fips module to the libcrypto list
  • Move all test infrastructure inside CMake This is tracked elsewhere, and is underway. (e.g. Valgrind and asan )

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

The nix shell is used by developers and the CI and the the codebuild/bin directory can be removed.

@dougch
Copy link
Contributor

dougch commented Jun 21, 2023

2/3 of the aarch64 PRs merged: #4045 and #4043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants