feat: pytest marks to selectively skip some tests #4542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Partial for #3841
Description of changes:
Adds a pytest mark to allow skipping tests based on current platform (x86 or arm) and if we detect a
nix devshell.Marks added to skip certain tests based on local testing.
Call-outs:
The mark
uncollect_if()was moved from conftest.py to the pytest.ini.While pytest.ini is normally at the root of the project, we've historically passed all of the arguments into pytest instead of using a configuration file.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Locally.
Is this a refactor change? No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.