Update nix corretto; make it platform aware.

[dougch]

Resolved issues:

none

Description of changes:

Add support for the linux-arm version of Amazon Corretto in nix development shells, and while we're here, bump the version from 8 to 17.

Call-outs:

We were still testing TLS1.1 in the java provider, which worked for Corretto 8, but has been disabled by default in newer jdk's.

Do we want to keep older/additional versions of corretto around for coverage reasons?

Until the nassl/sslyze install is fixed for arm, you must quote them out in nix/pyenv.nix to validate this change on arm. This change will still get tested for x86 in CI.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[toidiu]

Are we sure no one is using old corretto and or are we dropping support for older corretto version?

[maddeleine]

Are we sure no one is using old corretto and or are we dropping support for older corretto version?

What we're saying with this change is "the scenario where an s2n-tls endpoint negotiates with a corretto endpoint older than 17 is untested/unsupported". Which is an acceptable change since I'd rather us test with a newer corretto than an older one.

[toidiu]

What we're saying with this change is "the scenario where an s2n-tls endpoint negotiates with a corretto endpoint older than 17 is untested/unsupported". Which is an acceptable change since I'd rather us test with a newer corretto than an older one.

Can/should we test with both old and new or are we ok dropping support for old corretto.

[dougch]

Can/should we test with both old and new or are we ok dropping support for old Corretto.

8 is in long term support mode, so I'm gently suggesting we leave it behind.