ci: Valgrind and ASAN should by run with CMake

[jmayclin]

Problem:

Valgrind and Asan CI jobs have more compiler warnings enabled, which results in the frustrating experience of a job succeeding locally, but failing in CI for compiler warnings.

Solution:

In this case, I would argue that the best approach is to just port the asan (and maybe the valgrind) job to cmake, which should make it significantly easier for developers to run them locally.

For this asan job we should enable the more pedantic warnings that the make files are currently using.

Requirements / Acceptance Criteria:

I should be able to easily verify on my local machine that my build won't fail for silly compiler warning reasons in CI.

Out of scope:

Any CI jobs that aren't valgrind and ASAN.

[jmayclin]

I'll also give my 2 cents that this should live in a toolchain file cmake/toolchains/sanitary.toolchain rather than the main CMakeLists.txt file. This minimizes bloat in the CMake file and should hopefully make the codebuild spec easier to read.

phases:
  build:
    on-failure: ABORT
    commands:
      - cmake . -Bbuild -DCMAKE_TOOLCHAIN_FILE=cmake/toolchains/sanitary.toolchain
      - cmake --build ./build -j $(nproc)
  post_build:
    on-failure: ABORT
    commands:
      - CTEST_PARALLEL_LEVEL=$(nproc) make -C build test

[jmayclin]

And yet another pile-on that we likely do not need to be running with different versions of the same compiler for these kinds of checks. Currently we run valgrind with gcc 6 and gcc 9, and it is not entirely clear why. We do not expect valgrind runs to have different results with different versions of the same compiler, and if there are differences it would be a bug in the compiler, not our code.

So we should cleanup the CI option matrix as part of this work.

[jmayclin]

As part of this task, we should investigate whether the LD_PRELOAD allocator overrides can be removed. They are not used in the CMake unit tests.