Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version to v4.21.2 #201

Merged
merged 1 commit into from
Dec 10, 2024
Merged

updated version to v4.21.2 #201

merged 1 commit into from
Dec 10, 2024

Conversation

francescoopiccoli
Copy link
Contributor

@francescoopiccoli francescoopiccoli commented Dec 10, 2024

Version update to v4.21.2

This update fixes two minor issues related to the recently introduced up/down arrows prompt navigation (like in the terminal):

  1. When user is currently writing a prompt without sending it, and navigate through previous prompts via up/down arrows, and then goes back to the top of the list (current last unsent prompt), the unsent prompt was deleted, with this update the current unsent prompt is still visible and accessible. (see PR)
  2. In VSCode and JetBrains, we fix the way code attachments are shown (when navigating to previous prompts which have a code attachment) by removing ``` at the beginning and end of the code snippets and potentially avoiding any replacement of the first instance of ~~~~~~~~~~ in the code snippet (see PR)

A visual example for the second issue:
Original code attachment

void main() {
  print("~~~~~~~~~~");
  print("Hello World");
  print("Hello World");
}

Rendering before

` ` `
void main() {
  print("");
  print("Hello World");
  print("Hello World");
}
` ` `

Rendering after

void main() {
  print("~~~~~~~~~~");
  print("Hello World");
  print("Hello World");
}

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@francescoopiccoli francescoopiccoli linked an issue Dec 10, 2024 that may be closed by this pull request
4 tasks
@francescoopiccoli francescoopiccoli marked this pull request as ready for review December 10, 2024 13:58
@francescoopiccoli francescoopiccoli requested a review from a team as a code owner December 10, 2024 13:58
@dogusata dogusata merged commit 2aae8a8 into main Dec 10, 2024
2 checks passed
@dogusata dogusata deleted the frapicc/update-version branch December 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Up/down prompt history navigation causes extra ``` in code attachments
2 participants