Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid resetting last unsent user prompt when navigating with up and down arrows #198

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

francescoopiccoli
Copy link
Contributor

Problem

We should keep track of the last unsent user prompt when navigating with the up and down arrow through previous prompts. When the user navigates through previous prompts, they should be able to go back to the prompt they are currently writing which should not be reset. This behaviour is of particular relevance when writing a prompt and accidentally press the up or down arrow key, which would reset the prompt.

Solution

Keep track of the current prompt being written (last unsent user prompt)

Tests

  • I have tested this change on VSCode
  • I have tested this change on JetBrains

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@francescoopiccoli francescoopiccoli marked this pull request as ready for review December 9, 2024 10:43
@francescoopiccoli francescoopiccoli requested a review from a team as a code owner December 9, 2024 10:43
Jurredr
Jurredr previously approved these changes Dec 9, 2024
@francescoopiccoli francescoopiccoli merged commit 69cdd2e into main Dec 9, 2024
2 checks passed
@francescoopiccoli francescoopiccoli deleted the frapicc/fix-arrow-navigation branch December 9, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants