Fix code marks trimming for different ides #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
in our example mynah-ui we mark codeblock with ~~~~~~~~~~, different ides use ``` instead. This causes a small ui issue when navigating through prompts as the code blocks attached to previous prompts might not be trimmed correctly. More importantly, in this PR we make sure to remove the code marks ONLY if they appear at the very start of the codeAttachment, not the first occurrence. This issue could have potentially modified the user prompt if it contained an occurrence of ~~~~~~~~~~ while the code block was marked via the ``` marks. In that case navigating through prompts would have caused an input like:
to be transformed to
Solution
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.