Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/request: TestRequestCancelRetry fails due to timing #2840

Closed
jasdel opened this issue Sep 18, 2019 · 3 comments
Closed

aws/request: TestRequestCancelRetry fails due to timing #2840

jasdel opened this issue Sep 18, 2019 · 3 comments
Labels
bug This issue is a bug.

Comments

@jasdel
Copy link
Contributor

jasdel commented Sep 18, 2019

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

v1.2

Version of Go (go version)?

go1.5

What issue did you see?

https://travis-ci.org/aws/aws-sdk-go/jobs/584993972

If r.Send() manages to succeed despite being canceled, it will return nil, resulting in a panic when the test calls err.Error().
#2835 (comment)

Stack trace: #2835 (comment)

Steps to reproduce

Looks like the test case can fails due to timing of cancel.
@jasdel jasdel added the bug This issue is a bug. label Sep 18, 2019
This was referenced Sep 18, 2019
Merged
Merged
jasdel added a commit that referenced this issue Sep 27, 2019
@jasdel
Ensuren SDK's testing HTTP server usage are cleaned up (#2841)
ab0bbeb 
Ensure HTTP servers are cleaned up during testing after no longer needed. This was creating excessive noise in testing stack traces due to the number of background goroutines active.

Also updated SDK's unit tests to use verbose logging, have shorter runtime, and have a timeout fo 5m.

Related to #2840
skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this issue Sep 28, 2019
@jasdel @skotambkar
Ensuren SDK's testing HTTP server usage are cleaned up (aws#2841)
f7b7948 
Ensure HTTP servers are cleaned up during testing after no longer needed. This was creating excessive noise in testing stack traces due to the number of background goroutines active.

Also updated SDK's unit tests to use verbose logging, have shorter runtime, and have a timeout fo 5m.

Related to aws#2840
@skotambkar
Copy link
Contributor

Needs investigation: TestRequestCancelRetry fails for Go1.6,

https://travis-ci.org/aws/aws-sdk-go/jobs/590540416#L1827

@github-actions
Copy link

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 30, 2020
@github-actions github-actions bot closed this as completed Oct 5, 2020
@rittneje
Copy link
Contributor

@jasdel Please re-open this issue. I still see sporadic failures on this test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasdel @rittneje @skotambkar