Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Fix typo in Handlers doc comments #2835

Merged
merged 1 commit into from
Sep 18, 2019
Merged

aws: Fix typo in Handlers doc comments #2835

merged 1 commit into from
Sep 18, 2019

Conversation

rittneje
Copy link
Contributor

Fixed a few doc comment typos I found.

@rittneje
Copy link
Contributor Author

My best guess is that the test failure is due to an existing race condition.

err := r.Send()
if !strings.Contains(err.Error(), "canceled") {
t.Errorf("expect canceled in error, %v", err)
}

If r.Send() manages to succeed despite being canceled, it will return nil, resulting in a panic when the test calls err.Error().

@jasdel
Copy link
Contributor

jasdel commented Sep 18, 2019

--- FAIL: TestRequestCancelRetry (0.00s)

panic: runtime error: invalid memory address or nil pointer dereference [recovered]

	panic: runtime error: invalid memory address or nil pointer dereference

[signal 0xb code=0x1 addr=0x20 pc=0x4d698c]

goroutine 841 [running]:

testing.tRunner.func1(0xc820f610e0)

	/tmp/workdir/go/src/testing/testing.go:450 +0x1f5

github.com/aws/aws-sdk-go/aws/request_test.TestRequestCancelRetry(0xc820f610e0)

	/home/travis/gopath/src/github.com/aws/aws-sdk-go/aws/request/http_request_retry_test.go:32 +0x8ac

testing.tRunner(0xc820f610e0, 0x1397350)

	/tmp/workdir/go/src/testing/testing.go:456 +0xdd

created by testing.RunTests

	/tmp/workdir/go/src/testing/testing.go:561 +0xaa4

goroutine 1 [chan receive]:

testing.RunTests(0x105b930, 0x1397080, 0x50, 0x50, 0xc8201ae601)

	/tmp/workdir/go/src/testing/testing.go:562 +0xafa

testing.(*M).Run(0xc8232fff00, 0x1)

	/tmp/workdir/go/src/testing/testing.go:494 +0xe5

main.main()

	github.com/aws/aws-sdk-go/aws/request/_test/_testmain.go:234 +0x210

goroutine 17 [syscall, locked to thread]:

runtime.goexit()

	/tmp/workdir/go/src/runtime/asm_amd64.s:1721 +0x1

@jasdel
Copy link
Contributor

jasdel commented Sep 18, 2019

Also looks like TestEnforceShouldRetryCheck test case isn't cleanup up its server either.

@jasdel
Copy link
Contributor

jasdel commented Sep 18, 2019

Create #2840 for the test failure.

@jasdel jasdel changed the title fixing typos in doc comments aws: Fix typo in Handlers doc comments Sep 18, 2019
@jasdel jasdel merged commit 828e6a1 into aws:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants