Ensuren SDK's testing HTTP server usage are cleaned up #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
added
the
needs-review
jasdel
force-pushed
the
fixup/TestServer
branch
from
e565e43
to
fd523fc
Compare
|
|
jasdel
force-pushed
the
fixup/TestServer
branch
from
deef2c5
to
cd6ddb5
Compare
jasdel
force-pushed
the
fixup/TestServer
branch
from
5a095dc
to
dd15e2e
Compare
jasdel
force-pushed
the
fixup/TestServer
branch
from
6c193b4
to
a2ef28d
Compare
skmcgrail
approved these changes
Sep 27, 2019
This was referenced Sep 27, 2019
skotambkar
pushed a commit
to skotambkar/aws-sdk-go
that referenced
this pull request
Sep 28, 2019
Ensure HTTP servers are cleaned up during testing after no longer needed. This was creating excessive noise in testing stack traces due to the number of background goroutines active. Also updated SDK's unit tests to use verbose logging, have shorter runtime, and have a timeout fo 5m. Related to aws#2840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure HTTP servers are cleaned up during testing after no longer needed. This was creating excessive noise in testing stack traces due to the number of background goroutines active.
Also updated SDK's unit tests to use verbose logging, and have a timeout of 20s.
Related to #2840