Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eks): pass --use-max-pods to bootstrap options when false #4753

Merged
merged 4 commits into from
Oct 31, 2019
Merged

fix(eks): pass --use-max-pods to bootstrap options when false #4753

merged 4 commits into from
Oct 31, 2019

Conversation

progamesigner
Copy link
Contributor

The EKS useMaxPods in bootstrapOptions is dropped --use-max-pods when set
to false but in bootstrap.sh it would default to true and cause unexpected
stacks.

Fixes #4752

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@progamesigner progamesigner requested a review from eladb as a code owner October 30, 2019 06:15
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously requested changes Oct 30, 2019
View reviewed changes
packages/@aws-cdk/aws-eks/lib/user-data.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed eladb’s stale review October 31, 2019 04:00

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 22fe0ce into aws:master Oct 31, 2019
nmussy pushed a commit to logicgram/aws-cdk that referenced this pull request Oct 31, 2019
@progamesigner
fix(eks): pass --use-max-pods to bootstrap options when false (aws#…
e9e2a3c 
…4753)

* fix(eks): pass `--use-max-pods` to bootstrap options when false

* chore(eks): default useMaxPods to true and update tests accordingly

* fix(eks): fix eks integration tests in useMaxPods
@tomkivlin tomkivlin mentioned this pull request Nov 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-eks] EKS --use-max-pods=false not working
3 participants
@progamesigner @aws-cdk-automation @eladb