Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-eks] EKS --use-max-pods=false not working #4752

Closed
progamesigner opened this issue Oct 30, 2019 · 1 comment · Fixed by #4753
Closed

[aws-eks] EKS --use-max-pods=false not working #4752

progamesigner opened this issue Oct 30, 2019 · 1 comment · Fixed by #4753
Assignees
@eladb @iliapolo
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@progamesigner
Copy link
Contributor

In bootstrap.sh, option --use-max-pods can be true or false and default to true.

However, in CDK --use-max-pods option would be appended to extraArgs only if it's true and omitted when false. As a result, if I want to disable this behavior and pass false as bootstrapOptions, it would generate LaunchConfiguration with no --use-max-pods option and thus default to true in bootstrap.sh script. Which is not intended.

Reproduction Steps

Set useMaxPods to false in bootstrapOptions when pass options in AutoScalingGroup.

Error Log

No logs. Generated CF templates are not included desired option.

Environment

  • CLI Version: 1.13.1
  • Framework Version: 1.13.1
  • OS: MacOS
  • Language: TypeScript

This is 🐛 Bug Report
@progamesigner progamesigner added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2019
@eladb
Copy link
Contributor

eladb commented Oct 30, 2019

Thanks for the report

@eladb eladb added effort/small Small work item – less than a day of effort p1 @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service labels Oct 30, 2019
@eladb eladb self-assigned this Oct 30, 2019
@progamesigner progamesigner mentioned this issue Oct 30, 2019
Merged
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2019
@mergify mergify bot closed this as completed in #4753 Oct 31, 2019
@tomkivlin tomkivlin mentioned this issue Nov 1, 2019
Closed
@iliapolo iliapolo changed the title EKS --use-max-pods=false not working [aws-eks] EKS --use-max-pods=false not working Aug 16, 2020
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

@iliapolo iliapolo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eks): pass --use-max-pods to bootstrap options when false
4 participants
@eladb @iliapolo @progamesigner @SomayaB