Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] EKS --use-max-pods=false not working #4805

Closed
tomkivlin opened this issue Nov 1, 2019 · 3 comments
Closed

[aws-eks] EKS --use-max-pods=false not working #4805

tomkivlin opened this issue Nov 1, 2019 · 3 comments
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug.

Comments

@tomkivlin
Copy link

I am using a CF template to manage EKS Node Groups. When I pass --use-max-pods=false into the BootstrapArguments parameter, it appears to be ignored by the bootstrap.sh script, or some other component as there is still a limit being applied to each node.

Reproduction Steps

Pass --use-max-pods=false into the BootstrapArguments parameter of a CF template.

Error Log

No error. The nodes still have a pods entry in the allocatable section of their configuration when I interrogate with kubectl get nodes -o yaml.

Environment

  • CLI Version : 1.16.188
  • Framework Version: not sure - which framework?
  • OS : MacOS
  • Language : of what?

Other

Looks to be a duplicate of #4752 which should have been fixed in #4753?


This is 🐛 Bug Report

@tomkivlin tomkivlin added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2019
@tomkivlin
Copy link
Author

Other potentially useful information:

  • I am attempting this in eu-west-3 (Paris)
  • I am attempting this using t3.micro instances (my current workaround is to use t3.small to provide a larger allocatable value)

@SomayaB SomayaB added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Nov 1, 2019
@SomayaB
Copy link
Contributor

SomayaB commented Nov 1, 2019

Hi @tomkivlin, you are right this is a duplicate and the issue was fixed and merged yesterday. There hasn't been a new release yet with those changes so that's why you're still experiencing this issue unfortunately. The new release should be out in a few days.
I will close this issue. Feel free to reopen if once you get the new release you still encounter some problems.

@SomayaB SomayaB closed this as completed Nov 1, 2019
@tomkivlin
Copy link
Author

Ah gotcha - thanks @SomayaB, sorry for the impatience!

@iliapolo iliapolo changed the title EKS --use-max-pods=false not working [aws-eks] EKS --use-max-pods=false not working Aug 16, 2020
@iliapolo iliapolo removed the needs-triage This issue or PR still needs to be triaged. label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

4 participants