chore: tests don't run on Linux system #19989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first argument to `mkdtemp` is a *prefix*, not a *parent directory*. In other words, on a regular Linux system to following code: ``` mkdtemp(os.tmpdir()) ``` Tries to make a *sibling* of the temp directory instead of a child (for example, `/tmpABC123` instead of `/tmp/ABC123`), which then fails with "access denied". This doesn't fail on Mac because the `tmp` directory is in another directory with write permissions so we can create a sibling directory. And in CodeBuild we run as root so we have permissions to create a sibling dir in the root. Fix it for other systems.
|
|
otaviomacedo
approved these changes
Apr 20, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
The first argument to `mkdtemp` is a *prefix*, not a *parent directory*. In other words, on a regular Linux system the following code: ``` mkdtemp(os.tmpdir()) ``` Tries to make a *sibling* of the temp directory instead of a child (for example, `/tmpABC123` instead of `/tmp/ABC123`), which then fails with "access denied". This doesn't fail on Mac because the `tmp` directory is in another directory with write permissions so we can create a sibling directory. And in CodeBuild we run as root so we have permissions to create a sibling dir in the root. Fix it for other systems. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argument to
mkdtempis a prefix, not a parent directory.In other words, on a regular Linux system the following code:
Tries to make a sibling of the temp directory instead of a child (for
example,
/tmpABC123instead of/tmp/ABC123), which then fails with"access denied".
This doesn't fail on Mac because the
tmpdirectory is in anotherdirectory with write permissions so we can create a sibling directory.
And in CodeBuild we run as root so we have permissions to create a
sibling dir in the root.
Fix it for other systems.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license