Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tests don't run on Linux system #19989

Merged
merged 2 commits into from
Apr 20, 2022
Merged

chore: tests don't run on Linux system #19989

merged 2 commits into from
Apr 20, 2022

Commits on Apr 20, 2022

  1. chore: tests don't run on Linux system 

    The first argument to `mkdtemp` is a *prefix*, not a *parent directory*.

In other words, on a regular Linux system to following code:

```
mkdtemp(os.tmpdir())
```

Tries to make a *sibling* of the temp directory instead of a child (for
example, `/tmpABC123` instead of `/tmp/ABC123`), which then fails with
"access denied".

This doesn't fail on Mac because the `tmp` directory is in another
directory with write permissions so we can create a sibling directory.
And in CodeBuild we run as root so we have permissions to create a
sibling dir in the root.

Fix it for other systems.
    @rix0rrr
    rix0rrr committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4e4b78e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into huijbers/fix-test

    @mergify
    mergify[bot] committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    1a9c37d View commit details
    Browse the repository at this point in the history