Skip to content

Commit

Permalink
chore: tests don't run on Linux system (#19989)
Browse files Browse the repository at this point in the history
The first argument to `mkdtemp` is a *prefix*, not a *parent directory*.

In other words, on a regular Linux system the following code:

```
mkdtemp(os.tmpdir())
```

Tries to make a *sibling* of the temp directory instead of a child (for
example, `/tmpABC123` instead of `/tmp/ABC123`), which then fails with
"access denied".

This doesn't fail on Mac because the `tmp` directory is in another
directory with write permissions so we can create a sibling directory.
And in CodeBuild we run as root so we have permissions to create a
sibling dir in the root.

Fix it for other systems.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
rix0rrr committed Apr 20, 2022
1 parent 3698491 commit 2fbea60
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/integ-tests/test/manifest-writer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe(IntegManifestWriter, () => {
};

beforeEach(() => {
tmpDir = fs.mkdtempSync(os.tmpdir());
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'cdk-test'));
});

afterEach(() => {
Expand Down

0 comments on commit 2fbea60

Please sign in to comment.