-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to sync cni-metrics-helper helm chart to eks-charts #1794
Conversation
e477d49
to
ddc204f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have to update this - https://github.com/aws/amazon-vpc-cni-k8s/blob/master/Makefile#L42 so that this gets https://github.com/aws/amazon-vpc-cni-k8s/blob/master/Makefile#L286 both aws-vpc-cni and metrics helper as arguments.
ddc204f
to
4f3240f
Compare
@jayanthvn sorry for the delay, please review the latest change. Have modified both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
Discarding this PR as this workflow is not currently needed. This can be reintroduced in the future if needed |
We need to keep the PR open, it is reviewed and pending merge. This is needed to sync cni metrics helper to eks-charts. |
e8e4b5b
to
d608db8
Compare
What type of PR is this?
Enhancement
Which issue does this PR fix:
ORR task
What does this PR do / Why do we need it:
Currently, there are 3 args to run this command:
-b
, required, which is to assign binary basename-r
, optional, which is the Github repot to sync to in the form of "org/name"-n
, optional, which is to indicate whether to include the release note in the sync PRThis PR added a workflow to sync cni-metrics-helper helm chart to eks-charts repo, by using
-b
to choose which helm chart to sync.-b
:aws-vpc-cni
orcni-metrics-helper
. If invalid value is passed the script will quit.bash scripts/sync-to-eks-charts.sh -b aws-vpc-cni
bash scripts/sync-to-eks-charts.sh -b cni-metrics-helper
make ekscharts-sync-release
ormake ekscharts-sync
to sync both charts with/without release note.Testing done on this change:
Tested sync from aws/amazon-vpc-cni-k8s to oliviassss/eks-charts repo
Automation added to e2e:
N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.