Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to sync cni-metrics-helper helm chart to eks-charts #1794

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

oliviassss
Copy link
Contributor

@oliviassss oliviassss commented Dec 15, 2021

What type of PR is this?
Enhancement

Which issue does this PR fix:
ORR task

What does this PR do / Why do we need it:
Currently, there are 3 args to run this command:

  • -b, required, which is to assign binary basename
  • -r, optional, which is the Github repot to sync to in the form of "org/name"
  • -n, optional, which is to indicate whether to include the release note in the sync PR

This PR added a workflow to sync cni-metrics-helper helm chart to eks-charts repo, by using -b to choose which helm chart to sync.

  • The user can pass 2 values to -b: aws-vpc-cni or cni-metrics-helper. If invalid value is passed the script will quit.
  • Sample command to sync aws-vpc-cni helm chart to eks-chart: bash scripts/sync-to-eks-charts.sh -b aws-vpc-cni
  • Sample command to sync cni-metrics-helper to eks-chart: bash scripts/sync-to-eks-charts.sh -b cni-metrics-helper
  • Or use make command make ekscharts-sync-release or make ekscharts-syncto sync both charts with/without release note.

Testing done on this change:

Automation added to e2e:

N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A

Does this change require updates to the CNI daemonset config files to work?:

No
Does this PR introduce any user-facing change?:

No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@oliviassss oliviassss requested a review from a team as a code owner December 15, 2021 00:14
@oliviassss oliviassss force-pushed the sync_chart branch 3 times, most recently from e477d49 to ddc204f Compare December 20, 2021 20:54
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to update this - https://github.com/aws/amazon-vpc-cni-k8s/blob/master/Makefile#L42 so that this gets https://github.com/aws/amazon-vpc-cni-k8s/blob/master/Makefile#L286 both aws-vpc-cni and metrics helper as arguments.

@oliviassss
Copy link
Contributor Author

@jayanthvn sorry for the delay, please review the latest change. Have modified both make ekscharts-sync-release and make ekscharts-sync in Makefile.

@oliviassss oliviassss requested a review from jayanthvn January 13, 2022 22:08
jayanthvn
jayanthvn previously approved these changes Feb 28, 2022
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jayanthvn
jayanthvn previously approved these changes May 9, 2022
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added stale Issue or PR is stale and removed stale Issue or PR is stale labels Jul 9, 2022
@github-actions
Copy link

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Sep 22, 2022
@haouc haouc removed the stale Issue or PR is stale label Sep 27, 2022
@jdn5126
Copy link
Contributor

jdn5126 commented Oct 12, 2022

Discarding this PR as this workflow is not currently needed. This can be reintroduced in the future if needed

@jdn5126 jdn5126 closed this Oct 12, 2022
@jayanthvn
Copy link
Contributor

We need to keep the PR open, it is reviewed and pending merge. This is needed to sync cni metrics helper to eks-charts.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@jdn5126 jdn5126 merged commit c843292 into aws:master Dec 14, 2022
haouc pushed a commit to haouc/amazon-vpc-cni-k8s that referenced this pull request Dec 22, 2022
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 3, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 3, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 7, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 7, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 7, 2023
jdn5126 added a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants