Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cni-metrics-helper as a separate chart #588

Closed
wants to merge 1 commit into from

Conversation

majidazimi
Copy link

Signed-off-by: Majid Azimi s.azimigehraz@reply.de

Issue

There is currently an inactive PR to merge cni-metrics-helper into aws-vpc-cni chart. However it has introduced some custom templates that is not available in upstream which makes it hard to constantly pull changes from upstream.

Description of changes

This PR add cni-metrics-helper as a separate chart. It is a copy/paste of upstream chart (master branch) which makes it pretty easy to constantly pull upstream changes.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

This is a copy paste of upstream chart. Not much testing is needed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Majid Azimi <s.azimigehraz@reply.de>
@vara-bonthu
Copy link
Contributor

@majidazimi Thanks for raising this PR.

@jaypipes @bwagner5 @kishorj I thought of creating a Helm Chart for CNI Metrics Helper and i found this one. Would you be able to review this PR and merge it accordingly? This is a very useful Helm chart for monitoring VPC CNI

@jayanthvn
Copy link
Contributor

Thanks for the PR, can you please update the chart and image version? Please ref to https://github.com/aws/amazon-vpc-cni-k8s/tree/master/charts/cni-metrics-helper. Also we have a pending-merge PR aws/amazon-vpc-cni-k8s#1794 which will sync the cni-metrics-helper when the vpc cni new version release is cut.

@jdn5126
Copy link
Contributor

jdn5126 commented Jan 24, 2024

Closing as this was already completed

@jdn5126 jdn5126 closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants