Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document AWS_VPC_K8S_CNI_LOGLEVEL for cni-metric-helper helm chart #2226

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

csantanapr
Copy link
Contributor

What type of PR is this?

Document the variable AWS_VPC_K8S_CNI_LOGLEVEL and set the default value to INFO

Add one of the following:
cleanup
documentation

Which issue does this PR fix:
Fixes #2207

Document environment variable `AWS_VPC_K8S_CNI_LOGLEVEL` for cni-metric-helper

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@csantanapr csantanapr requested a review from a team as a code owner January 22, 2023 19:01
Copy link
Contributor

@jdn5126 jdn5126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csantanapr thank you for the contribution! This change looks good to me, though we should also increment the chart revision. @jayanthvn are you ok with this default changing?

@jdn5126
Copy link
Contributor

jdn5126 commented Jan 25, 2023

@csantanapr thank you for the contribution! This change looks good to me, though we should also increment the chart revision. @jayanthvn are you ok with this default changing?

Discussed offline and changing this log default in the chart is fine. @csantanapr I can merge this after you increment the Chart version: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/cni-metrics-helper/Chart.yaml#L3

@jayanthvn
Copy link
Contributor

@csantanapr thank you for the contribution! This change looks good to me, though we should also increment the chart revision. @jayanthvn are you ok with this default changing?

Discussed offline and changing this log default in the chart is fine. @csantanapr I can merge this after you increment the Chart version: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/cni-metrics-helper/Chart.yaml#L3

@jdn5126 CNI has default as DEBUG, any specific reason to make it INFO?

@jdn5126
Copy link
Contributor

jdn5126 commented Jan 25, 2023

@csantanapr thank you for the contribution! This change looks good to me, though we should also increment the chart revision. @jayanthvn are you ok with this default changing?

Discussed offline and changing this log default in the chart is fine. @csantanapr I can merge this after you increment the Chart version: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/cni-metrics-helper/Chart.yaml#L3

@jdn5126 CNI has default as DEBUG, any specific reason to make it INFO?

For CNI Metrics Helper, I think INFO is a reasonable default, as some logs like https://github.com/aws/amazon-vpc-cni-k8s/blob/master/cmd/cni-metrics-helper/metrics/cni_metrics.go#L196 are extremely verbose, adding to ops cost as mentioned in #2207 . This is a helpful log if we need to debug what is sent to CloudWatch, though.

Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
@jdn5126 jdn5126 merged commit 666ee0c into aws:master Jan 27, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 2, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 2, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 3, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 3, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 7, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 7, 2023
jdn5126 added a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Feb 7, 2023
jdn5126 added a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable debug level for cni-metrics?
3 participants