-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: document AWS_VPC_K8S_CNI_LOGLEVEL for cni-metric-helper helm chart #2226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csantanapr thank you for the contribution! This change looks good to me, though we should also increment the chart revision. @jayanthvn are you ok with this default changing?
1364a78
to
c01c8b4
Compare
Discussed offline and changing this log default in the chart is fine. @csantanapr I can merge this after you increment the Chart version: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/cni-metrics-helper/Chart.yaml#L3 |
@jdn5126 CNI has default as DEBUG, any specific reason to make it INFO? |
For CNI Metrics Helper, I think INFO is a reasonable default, as some logs like https://github.com/aws/amazon-vpc-cni-k8s/blob/master/cmd/cni-metrics-helper/metrics/cni_metrics.go#L196 are extremely verbose, adding to ops cost as mentioned in #2207 . This is a helpful log if we need to debug what is sent to CloudWatch, though. |
c01c8b4
to
2ba269b
Compare
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Carlos Santana <csantana23@gmail.com>
What type of PR is this?
Document the variable
AWS_VPC_K8S_CNI_LOGLEVEL
and set the default value toINFO
Add one of the following:
cleanup
documentation
Which issue does this PR fix:
Fixes #2207
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.